You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "piyush280599 (via GitHub)" <gi...@apache.org> on 2023/02/03 07:23:35 UTC
[GitHub] [shardingsphere] piyush280599 opened a new pull request, #23958: Removed extra symbol
piyush280599 opened a new pull request, #23958:
URL: https://github.com/apache/shardingsphere/pull/23958
Fixes #ISSUSE_ID.#23951
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ x] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #23958: Removed extra symbol
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #23958:
URL: https://github.com/apache/shardingsphere/pull/23958#issuecomment-1415476170
Hi @piyush280599 ,
Welcome to Apache ShardingSphere.
ShardingSphere's documentation contains English and Chinese language versions, please update both files together:
- https://github.com/apache/shardingsphere/blob/master/docs/document/content/features/readwrite-splitting/_index.en.md
- https://github.com/apache/shardingsphere/blob/master/docs/document/content/features/readwrite-splitting/_index.cn.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on pull request #23958: Removed extra symbol
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on PR #23958:
URL: https://github.com/apache/shardingsphere/pull/23958#issuecomment-1415737507
@piyush280599 Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23958: Removed extra symbol
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #23958:
URL: https://github.com/apache/shardingsphere/pull/23958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #23958: Removed extra symbol
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #23958:
URL: https://github.com/apache/shardingsphere/pull/23958#discussion_r1095673240
##########
docs/document/content/features/readwrite-splitting/_index.cn.md:
##########
@@ -36,4 +36,4 @@ chapter = true
## 相关参考
[Java API](/cn/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting)\
Review Comment:
The `\` on line 38 is also unnecessary, please remove it, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org