You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by phiradet <gi...@git.apache.org> on 2017/11/22 04:56:06 UTC

[GitHub] bahir-flink pull request #23: [BAHIR-145] Fix the JedisCluster function call...

GitHub user phiradet opened a pull request:

    https://github.com/apache/bahir-flink/pull/23

    [BAHIR-145] Fix the JedisCluster function called when performing PFADD

    Hi All,
    
    As described in the bug report, there is a bug in the Streaming Flink connector for Redis (Cluster). The connector cannot perform PFADD correctly because of a wrong function call. Please check this fix.
    
    Best regards,
    Phiradet

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phiradet/bahir-flink BAHIR-145_flink_sink_for_redis_cannot_perform_pfadd

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir-flink/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 2e20f345319e5ea6996b40f1b032678d95d3bc32
Author: Bang, Phiradet <ph...@rakuten.com>
Date:   2017-11-22T04:48:45Z

    [BAHIR-145] Fix the JedisCluster function called when performing PFADD

----


---

[GitHub] bahir-flink issue #23: [BAHIR-145] Fix the JedisCluster function called when...

Posted by yew1eb <gi...@git.apache.org>.

Github user yew1eb commented on the issue:

    https://github.com/apache/bahir-flink/pull/23
  
    LGTM.
    +1 for merge.


---

[GitHub] bahir-flink issue #23: [BAHIR-145] Fix the JedisCluster function called when...

Posted by phiradet <gi...@git.apache.org>.

Github user phiradet commented on the issue:

    https://github.com/apache/bahir-flink/pull/23
  
    Great, thanks for checking 👍 


---

[GitHub] bahir-flink pull request #23: [BAHIR-145] Fix the JedisCluster function call...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/bahir-flink/pull/23


---

[GitHub] bahir-flink issue #23: [BAHIR-145] Fix the JedisCluster function called when...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the issue:

    https://github.com/apache/bahir-flink/pull/23
  
    Thanks a lot for fixing this issue.
    
    Merging the change.


---