[GitHub] [sling-org-apache-sling-featureflags] rombert commented on a diff in pull request #1: SLING-11333: Sling update to 47

[GitBox <gi...@apache.org>]

rombert commented on code in PR #1:
URL: https://github.com/apache/sling-org-apache-sling-featureflags/pull/1#discussion_r880573182


##########
pom.xml:
##########
@@ -21,37 +21,32 @@
     <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>org.apache.sling</groupId>
-        <artifactId>sling</artifactId>
-        <version>30</version>
+        <artifactId>sling-bundle-parent</artifactId>
+        <version>47</version>
         <relativePath />
     </parent>
     
     <groupId>org.apache.sling</groupId>
     <artifactId>org.apache.sling.featureflags</artifactId>
     <version>1.2.3-SNAPSHOT</version>
-    <packaging>bundle</packaging>
     <name>Apache Sling Feature Flags</name>
     
     <scm>
         <connection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-featureflags.git</connection>
         <developerConnection>scm:git:https://gitbox.apache.org/repos/asf/sling-org-apache-sling-featureflags.git</developerConnection>
         <url>https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-featureflags.git</url>
-      <tag>HEAD</tag>
-  </scm>
+        <tag>HEAD</tag>
+    </scm>
+
+    <properties>
+        <project.build.outputTimestamp>1</project.build.outputTimestamp>
+    </properties>
 
     <build>
         <plugins>
             <plugin>
-                <groupId>org.apache.felix</groupId>
-                <artifactId>maven-bundle-plugin</artifactId>
-                <extensions>true</extensions>
-                <configuration>
-                    <instructions>                
-                        <Require-Capability>
-                            osgi.implementation;filter:="(&amp;(osgi.implementation=osgi.http)(version&gt;=1.0)(!(version&gt;=2.0)))"

Review Comment:
   The manifest of the new bundle does not have require this capability anymore. Was this intentional?
   
   ```
    ADDED      HEADER     Require-Capability:osgi.extender;filter:="(&(osgi.extender=osgi.component)(version>=1.3.0)(!(version>=2.0.0)))",osgi.implementation;filter:="(&(osgi.implementation=osgi.http)(version>=1.0)(!(version>=2.0)))",osgi.service;filter:="(objectClass=org.apache.sling.featureflags.Feature)";effective:=active;resolution:=optional;cardinality:=multiple,osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.7))"
    REMOVED    HEADER     Require-Capability:osgi.service;filter:="(objectClass=org.apache.sling.featureflags.Feature)";effective:=active;resolution:=optional;cardinality:=multiple,osgi.extender;filter:="(&(osgi.extender=osgi.component)(version>=1.4.0)(!(version>=2.0.0)))",osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org