You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/09 13:00:34 UTC

[GitHub] [airflow] bradarndt commented on a change in pull request #17477: Open relative extra links in place

bradarndt commented on a change in pull request #17477:
URL: https://github.com/apache/airflow/pull/17477#discussion_r685170802



##########
File path: airflow/www/static/js/dag.js
##########
@@ -190,6 +190,8 @@ export function callModal(t, d, extraLinks, tryNumbers, sd) {
           cache: false,
           success(data) {
             externalLink.attr('href', data.url);
+            if(/^(?:[a-z]+:)?\/\//.test(data.url))
+              externalLink.attr('target', '_blank');

Review comment:
       Thanks for the review!  Change made in commit https://github.com/apache/airflow/pull/17477/commits/267eec89a1a0c764c85d302e5d9a2af424c6b3f6

##########
File path: airflow/www/static/js/dag.js
##########
@@ -190,6 +190,8 @@ export function callModal(t, d, extraLinks, tryNumbers, sd) {
           cache: false,
           success(data) {
             externalLink.attr('href', data.url);
+            if(/^(?:[a-z]+:)?\/\//.test(data.url))

Review comment:
       Thanks for the review!  Change made in commit https://github.com/apache/airflow/pull/17477/commits/267eec89a1a0c764c85d302e5d9a2af424c6b3f6




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org