You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2014/09/29 08:20:59 UTC
git commit: ISIS-907: typical length for enums max of toString() and
name().
Repository: isis
Updated Branches:
refs/heads/master 73298e02c -> 0d5d3eb43
ISIS-907: typical length for enums max of toString() and name().
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/0d5d3eb4
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/0d5d3eb4
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/0d5d3eb4
Branch: refs/heads/master
Commit: 0d5d3eb43d1c23a2ce66238e4ac57762ce1aabcc
Parents: 73298e0
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Mon Sep 29 07:20:44 2014 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Mon Sep 29 07:20:44 2014 +0100
----------------------------------------------------------------------
.../facets/object/choices/enums/EnumValueSemanticsProvider.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/0d5d3eb4/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/enums/EnumValueSemanticsProvider.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/enums/EnumValueSemanticsProvider.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/enums/EnumValueSemanticsProvider.java
index 561ce05..0f40974 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/enums/EnumValueSemanticsProvider.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/choices/enums/EnumValueSemanticsProvider.java
@@ -42,7 +42,9 @@ public class EnumValueSemanticsProvider<T extends Enum<T>> extends ValueSemantic
private static <T extends Enum<T>> int typicalLengthFor(final Class<T> adaptedClass) {
int max = Integer.MIN_VALUE;
for(T e: adaptedClass.getEnumConstants()) {
- max = Math.max(max, e.name().length());
+ final int nameLength = e.name().length();
+ final int toStringLength = e.toString().length();
+ max = Math.max(max, Math.max(nameLength, toStringLength));
}
return max;
}