[GitHub] [solr] patsonluk commented on pull request #1237: SOLR-16586: Log start of SearchHandler#handleRequestBody

[GitBox <gi...@apache.org>]

patsonluk commented on PR #1237:
URL: https://github.com/apache/solr/pull/1237#issuecomment-1349536907

   > Doesn't [this](https://github.com/apache/solr/blob/6869ec97c7a59cc6acd001eb592b98ea90679fb8/solr/core/src/java/org/apache/solr/core/SolrCore.java#L2861-L2864) allow to achieve essentially the same thing (pre-logging requests), by configuring logging to:
   > 
   > ```
   > org.apache.solr.core.SolrCore.Request=DEBUG
   > ```
   
   That's a good point @magibney ! I guess for our own usage, we were having issues with Search queries in particular and didn't want to enable debug for SolrCore for that, which could create quite a bit of noise. 
   
   However, from general Solr perspective, it does not bring much values to have 2 different debug pieces with very similar info. The scope difference - `SolrCore` vs `SearchHandler` probably does not warrant the extra change. I will keep the change to our own local version, and retract this PR for now.
   
   Thank you for all the comments and help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org