[GitHub] [solr] cpoerschke opened a new pull request #478: SOLR-15873: factor out a ReRankRescorer class, simplify LTR[Interleaving]Rescorer code

[GitBox <gi...@apache.org>]

cpoerschke opened a new pull request #478:
URL: https://github.com/apache/solr/pull/478


   _(Keeping this PR as "draft" whilst the "keep or not keep" discussion in SOLR-15873 is underway and also because this PR includes the #470 changes.)_
   
   https://issues.apache.org/jira/browse/SOLR-15873
   
   The Lucene `Rescorer.rescore` API signature takes three arguments: `rescore(IndexSearcher searcher, TopDocs firstPassTopDocs, int topN)`
   
   The Solr `ReRankCollector` caps the number of documents that are passed to the `rescore` method so that `topN == firstPassTopDocs.scoreDocs.length` is always the case.
   
   This pull request introduces a `ReRankRescorer` class for the specific `ReRankCollector` use case i.e. a two arguments API signature variant `rescore(IndexSearcher searcher, TopDocs firstPassTopDocs)` with non-support of the three argument variant.
   
   Then the `LTR[Interleaving]Rescorer` logic can then be simplified by making use of the `topN == firstPassTopDocs.scoreDocs.length` condition.
   
   Existing `LTR[Interleaving]Rescorer` APIs that support `topN != firstPassTopDocs.scoreDocs.length` are retained with `@deprecated` annotation for backwards compatibility and with the intention to remove them in the next or a subsequent Solr version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org