[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1342
  
    @bbende @randerzander 
    
    Sorry for taking long, it took time to confirm results and consider how the result should be..
    Please take a look on the table in previous comment, and let me know how you think. I added additional commit to address those concerns.
    
    In addition to that, I'd like to have attribute key names like `s2s.remote.address` or `s2s.client.address` and `s2s.server.address` to describe which host the value represents more clearly.
    
    Also, I'd like to add some unit test cases to protect it from breaking in the future. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---