You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "lzlfred (via GitHub)" <gi...@apache.org> on 2023/12/06 01:17:35 UTC
[PR] Support write partition values to data files in FileFormatWritter [spark]
lzlfred opened a new pull request, #44195:
URL: https://github.com/apache/spark/pull/44195
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Support write partition values to data files in FileFormatWritter
### Why are the changes needed?
TBD.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual test with set flag to true and write parquet files.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46279][SQL] Support write partition values to data files in FileFormatWritter [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44195:
URL: https://github.com/apache/spark/pull/44195#discussion_r1416906431
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##########
@@ -52,6 +52,11 @@ object DataSourceUtils extends PredicateHelper {
*/
val PARTITION_OVERWRITE_MODE = "partitionOverwriteMode"
+ /**
+ * The key control if it should write partition columns to data files
+ */
+ val WRITE_PARTITION_COLUMNS = "writePartitionColumns"
Review Comment:
We should probably document this in the user-facing documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46279][SQL] Support write partition values to data files in FileFormatWritter [spark]
Posted by "lzlfred (via GitHub)" <gi...@apache.org>.
lzlfred commented on code in PR #44195:
URL: https://github.com/apache/spark/pull/44195#discussion_r1418363798
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala:
##########
@@ -52,6 +52,11 @@ object DataSourceUtils extends PredicateHelper {
*/
val PARTITION_OVERWRITE_MODE = "partitionOverwriteMode"
+ /**
+ * The key control if it should write partition columns to data files
+ */
+ val WRITE_PARTITION_COLUMNS = "writePartitionColumns"
Review Comment:
added in the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46279][SQL] Support write partition values to data files in FileFormatWritter [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44195:
URL: https://github.com/apache/spark/pull/44195#issuecomment-2002201496
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46279][SQL] Support write partition values to data files in FileFormatWritter [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #44195: [SPARK-46279][SQL] Support write partition values to data files in FileFormatWritter
URL: https://github.com/apache/spark/pull/44195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org