You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@locus.apache.org on 2000/12/29 15:11:14 UTC

cvs commit: httpd-2.0/modules/experimental mod_ext_filter.c

trawick     00/12/29 06:11:14

  Modified:    .        CHANGES
               modules/experimental mod_ext_filter.c
  Log:
  Fix a segfault caused by mod_ext_filter when the external filter
  program does not exist.
  
  I wish I understood why I didn't hit this problem in the normal
  case :(
  
  Revision  Changes    Path
  1.29      +3 -0      httpd-2.0/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/CHANGES,v
  retrieving revision 1.28
  retrieving revision 1.29
  diff -u -r1.28 -r1.29
  --- CHANGES	2000/12/29 14:08:20	1.28
  +++ CHANGES	2000/12/29 14:11:10	1.29
  @@ -1,5 +1,8 @@
   Changes with Apache 2.0b1
   
  +  *) Fix a segfault caused by mod_ext_filter when the external filter 
  +     program does not exist. [Jeff Trawick]
  +
     *) Fix an output truncation error when on an HTTP >= 1.0 request an
        object of size between DEFAULT_BUCKET_SIZE and AP_MIN_BYTES_TO_WRITE 
        was served through mod_charset_lite (or anything else that would
  
  
  
  1.5       +3 -1      httpd-2.0/modules/experimental/mod_ext_filter.c
  
  Index: mod_ext_filter.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_ext_filter.c,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- mod_ext_filter.c	2000/12/11 19:02:15	1.4
  +++ mod_ext_filter.c	2000/12/29 14:11:12	1.5
  @@ -421,7 +421,9 @@
        * be open.
        */
   
  -    apr_register_cleanup(ctx->p, ctx->proc->in, NULL, ef_close_file);
  +    apr_register_cleanup(ctx->p, ctx->proc->in, 
  +                         apr_null_cleanup, /* other mechanism */
  +                         ef_close_file);
   
   #if APR_FILES_AS_SOCKETS
       {