You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sanjanarampurkottur01 (via GitHub)" <gi...@apache.org> on 2023/11/22 04:59:45 UTC
[PR] Refactoring deficient encapsulation [commons-dbutils]
sanjanarampurkottur01 opened a new pull request, #221:
URL: https://github.com/apache/commons-dbutils/pull/221
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactoring deficient encapsulation [commons-dbutils]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #221:
URL: https://github.com/apache/commons-dbutils/pull/221#issuecomment-1822572346
## [Codecov](https://app.codecov.io/gh/apache/commons-dbutils/pull/221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `2 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`14124c2`)](https://app.codecov.io/gh/apache/commons-dbutils/commit/14124c23e6aeb792005baaa1ebdc753574f31e9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 62.63% compared to head [(`5358156`)](https://app.codecov.io/gh/apache/commons-dbutils/pull/221?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 62.63%.
| [Files](https://app.codecov.io/gh/apache/commons-dbutils/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rg/apache/commons/dbutils/AbstractQueryRunner.java](https://app.codecov.io/gh/apache/commons-dbutils/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvZGJ1dGlscy9BYnN0cmFjdFF1ZXJ5UnVubmVyLmphdmE=) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/commons-dbutils/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #221 +/- ##
=========================================
Coverage 62.63% 62.63%
Complexity 411 411
=========================================
Files 39 39
Lines 1381 1381
Branches 104 104
=========================================
Hits 865 865
Misses 467 467
Partials 49 49
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-dbutils/pull/221?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactoring deficient encapsulation [commons-dbutils]
Posted by "sanjanarampurkottur01 (via GitHub)" <gi...@apache.org>.
sanjanarampurkottur01 commented on PR #221:
URL: https://github.com/apache/commons-dbutils/pull/221#issuecomment-1826439432
These changes are not taken into account, hence closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactoring deficient encapsulation [commons-dbutils]
Posted by "sanjanarampurkottur01 (via GitHub)" <gi...@apache.org>.
sanjanarampurkottur01 closed pull request #221: Refactoring deficient encapsulation
URL: https://github.com/apache/commons-dbutils/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org