You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2023/01/09 03:42:09 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1219: Persist the cluster nodes info after applying the cluster topology

git-hulk commented on code in PR #1219:
URL: https://github.com/apache/incubator-kvrocks/pull/1219#discussion_r1064266761


##########
src/commands/redis_cmd.cc:
##########
@@ -5304,6 +5308,9 @@ class CommandClusterX : public Commander {
     } else {
       *output = Redis::Error("Invalid cluster command options");
     }
+    if (needPersistNodesInfo) {

Review Comment:
   Yes, it makes sense. Will resolve it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org