[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5309: Decouple Schema from RecordReader and StreamMessageDecoder

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #5309:
URL: https://github.com/apache/incubator-pinot/pull/5309#discussion_r416225407



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/MultiplePinotSegmentRecordReader.java
##########
@@ -64,7 +63,7 @@ public MultiplePinotSegmentRecordReader(@Nonnull List<File> indexDirs)
    * @param schema input schema that is a subset of the segment schema
    * @param sortOrder a list of column names that represent the sorting order
    */
-  public MultiplePinotSegmentRecordReader(@Nonnull List<File> indexDirs, @Nullable Schema schema,
+  public MultiplePinotSegmentRecordReader(List<File> indexDirs, @Nullable Schema schema,

Review comment:
       I kept the schema for pinot segment backed record readers because the schema is extracted from the file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org