You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/02 23:46:04 UTC

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40372/
-----------------------------------------------------------

(Updated Dec. 2, 2015, 2:46 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
-------

Relocate containerizer isolator files under mesos containerizer.


Diffs (updated)
-----

  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
  src/Makefile.am 0409491b92c9720d60ad76fdbc2edff554fb4965 
  src/slave/containerizer/isolator.hpp  
  src/slave/containerizer/isolator.cpp 6cc9b8342138ba76581647c95b1b9bac7e12f64f 
  src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 558071667f6ec9292af6aa571457f4a125ad8eea 
  src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 9d2a48a47b0628f70a910f9a1e507c4b45032667 
  src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp b8809c4040d02a253b4c10af1d0dcd28e816a84c 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 8f7ff39bdfcfc6e6e443959dbdc145d9ebe92685 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 3241dbc3dd4283d06f165fd0946418bbf6b88eb5 
  src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 6b6c8ce755b40ed2c827f6d4dab1af2a158bb2f9 
  src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 7ad6858692185d04b00fabb21c9fbd3ed6e39225 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp eaea644cc93601af9cf47ba3ac4b2b1c31a00f7a 
  src/slave/containerizer/mesos/isolators/posix.hpp d683f74f3e2abfcf371fee63a61ff5e28d1a7526 
  src/slave/containerizer/mesos/isolators/posix/disk.hpp 09836763287dfa6870f187d261bc22c24438dd97 
  src/tests/containerizer/isolator.hpp e49bc3ab0323ae1cf2cfb81c53f5ee0f57dd0b06 
  src/tests/containerizer/mesos_containerizer_tests.cpp fe679354d04d68b68e168cd8c4eab23898f6532f 

Diff: https://reviews.apache.org/r/40372/diff/


Testing
-------

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 40372: Relocate containerizer isolator files under mesos containerizer.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40372/#review108746
-----------------------------------------------------------

Ship it!



src/tests/containerizer/mesos_containerizer_tests.cpp (lines 45 - 48)
<https://reviews.apache.org/r/40372/#comment168208>

    why this change?


- Jie Yu


On Dec. 2, 2015, 10:46 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40372/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 10:46 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Relocate containerizer isolator files under mesos containerizer.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
>   src/Makefile.am 0409491b92c9720d60ad76fdbc2edff554fb4965 
>   src/slave/containerizer/isolator.hpp  
>   src/slave/containerizer/isolator.cpp 6cc9b8342138ba76581647c95b1b9bac7e12f64f 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 558071667f6ec9292af6aa571457f4a125ad8eea 
>   src/slave/containerizer/mesos/isolators/cgroups/mem.hpp 9d2a48a47b0628f70a910f9a1e507c4b45032667 
>   src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp b8809c4040d02a253b4c10af1d0dcd28e816a84c 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 8f7ff39bdfcfc6e6e443959dbdc145d9ebe92685 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 3241dbc3dd4283d06f165fd0946418bbf6b88eb5 
>   src/slave/containerizer/mesos/isolators/filesystem/shared.hpp 6b6c8ce755b40ed2c827f6d4dab1af2a158bb2f9 
>   src/slave/containerizer/mesos/isolators/namespaces/pid.hpp 7ad6858692185d04b00fabb21c9fbd3ed6e39225 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.hpp eaea644cc93601af9cf47ba3ac4b2b1c31a00f7a 
>   src/slave/containerizer/mesos/isolators/posix.hpp d683f74f3e2abfcf371fee63a61ff5e28d1a7526 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 09836763287dfa6870f187d261bc22c24438dd97 
>   src/tests/containerizer/isolator.hpp e49bc3ab0323ae1cf2cfb81c53f5ee0f57dd0b06 
>   src/tests/containerizer/mesos_containerizer_tests.cpp fe679354d04d68b68e168cd8c4eab23898f6532f 
> 
> Diff: https://reviews.apache.org/r/40372/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>