You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/03/12 08:50:19 UTC
[GitHub] [calcite] danny0405 opened a new pull request #1856: [CALCITE-3856]
Remove code to be removed before 1.23
danny0405 opened a new pull request #1856: [CALCITE-3856] Remove code to be removed before 1.23
URL: https://github.com/apache/calcite/pull/1856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1856:
[CALCITE-3856] Remove code to be removed before 1.23
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1856: [CALCITE-3856] Remove code to be removed before 1.23
URL: https://github.com/apache/calcite/pull/1856#discussion_r391475192
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalJoin.java
##########
@@ -170,36 +170,6 @@ public static LogicalJoin create(RelNode left, RelNode right, List<RelHint> hint
variablesSet, joinType, semiJoinDone, systemFieldList);
}
- @Deprecated // to be removed before 1.23
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, Set<CorrelationId> variablesSet, JoinRelType joinType) {
- return create(left, right, ImmutableList.of(), condition, variablesSet,
- joinType, false, ImmutableList.of());
- }
-
- @Deprecated // to be removed before 1.23
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, Set<CorrelationId> variablesSet, JoinRelType joinType,
- boolean semiJoinDone, ImmutableList<RelDataTypeField> systemFieldList) {
- return create(left, right, ImmutableList.of(), condition, variablesSet,
- joinType, semiJoinDone, systemFieldList);
- }
-
- @Deprecated // to be removed before 2.0
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, JoinRelType joinType, Set<String> variablesStopped,
- boolean semiJoinDone, ImmutableList<RelDataTypeField> systemFieldList) {
- return create(left, right, condition, CorrelationId.setOf(variablesStopped),
- joinType, semiJoinDone, systemFieldList);
- }
-
- @Deprecated // to be removed before 2.0
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, JoinRelType joinType, Set<String> variablesStopped) {
Review comment:
These 2 create method are also removed, because i think the `create#` method is low frequency used API (usuallu we use the `RelBuilder`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1856:
[CALCITE-3856] Remove code to be removed before 1.23
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1856: [CALCITE-3856] Remove code to be removed before 1.23
URL: https://github.com/apache/calcite/pull/1856#discussion_r391475192
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalJoin.java
##########
@@ -170,36 +170,6 @@ public static LogicalJoin create(RelNode left, RelNode right, List<RelHint> hint
variablesSet, joinType, semiJoinDone, systemFieldList);
}
- @Deprecated // to be removed before 1.23
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, Set<CorrelationId> variablesSet, JoinRelType joinType) {
- return create(left, right, ImmutableList.of(), condition, variablesSet,
- joinType, false, ImmutableList.of());
- }
-
- @Deprecated // to be removed before 1.23
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, Set<CorrelationId> variablesSet, JoinRelType joinType,
- boolean semiJoinDone, ImmutableList<RelDataTypeField> systemFieldList) {
- return create(left, right, ImmutableList.of(), condition, variablesSet,
- joinType, semiJoinDone, systemFieldList);
- }
-
- @Deprecated // to be removed before 2.0
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, JoinRelType joinType, Set<String> variablesStopped,
- boolean semiJoinDone, ImmutableList<RelDataTypeField> systemFieldList) {
- return create(left, right, condition, CorrelationId.setOf(variablesStopped),
- joinType, semiJoinDone, systemFieldList);
- }
-
- @Deprecated // to be removed before 2.0
- public static LogicalJoin create(RelNode left, RelNode right,
- RexNode condition, JoinRelType joinType, Set<String> variablesStopped) {
Review comment:
These 2 create method are also removed, because i think the `create#` method is low frequency used API (usually we use the `RelBuilder`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 merged pull request #1856: [CALCITE-3856]
Remove code to be removed before 1.23
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #1856: [CALCITE-3856] Remove code to be removed before 1.23
URL: https://github.com/apache/calcite/pull/1856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services