You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@hotmail.com> on 2013/08/09 19:25:00 UTC
Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/
-----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-166
Repository: helix-git
Description
-------
Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
1. Any issues with backward compatibility
2. Naming convention issues
3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
Diffs
-----
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
recipes/distributed-lock-manager/README.md fdba382
recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
Diff: https://reviews.apache.org/r/13444/diff/
Testing
-------
All tests pass locally.
Thanks,
Kanak Biscuitwala
Re: Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/#review24933
-----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/model/IdealState.java
<https://reviews.apache.org/r/13444/#comment49083>
could we annotate IdealStateModeProperty and any related methods as @deprecate?
helix-core/src/test/java/org/apache/helix/model/TestIdealState.java
<https://reviews.apache.org/r/13444/#comment49089>
could you add an integration test to verify that new controller is compatible with old format of ideal-state. see TestDisable#testDisableNodeCustomIS() as an example of simple integration test.
- Zhen Zhang
On Aug. 9, 2013, 5:24 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13444/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:24 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-166
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
>
> 1. Any issues with backward compatibility
> 2. Naming convention issues
> 3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
>
>
> Diffs
> -----
>
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
> helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
> helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
> helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
> helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
> helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
> helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
> helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
> helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
> helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
> helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
> helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
> helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
> helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
> helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
> helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
> helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
> helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
> helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
> helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
> helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
> helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
> helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
> recipes/distributed-lock-manager/README.md fdba382
> recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
> recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
> recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
> recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
>
> Diff: https://reviews.apache.org/r/13444/diff/
>
>
> Testing
> -------
>
> All tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/#review25125
-----------------------------------------------------------
Ship it!
Please file a backward compatibility jira, we need to ensure that before we make the new release.
- Kishore Gopalakrishna
On Aug. 10, 2013, 1:12 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13444/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 1:12 a.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-166
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
>
> 1. Any issues with backward compatibility
> 2. Naming convention issues
> 3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
>
>
> Diffs
> -----
>
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
> helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java 7ba0dbe
> helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
> helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
> helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
> helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
> helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
> helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
> helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
> helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
> helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
> helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
> helix-core/src/main/java/org/apache/helix/tools/ZkLogCSVFormatter.java 1618eee
> helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
> helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
> helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
> helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
> helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleCalcStageCompatibility.java PRE-CREATION
> helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleStateCalcStage.java effea2c
> helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java c0b6528
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
> helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java df32c4e
> helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
> helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
> helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
> helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
> helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java 4e52444
> helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
> helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java 403864a
> helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
> helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
> recipes/distributed-lock-manager/README.md fdba382
> recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
> recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
> recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
> recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
>
> Diff: https://reviews.apache.org/r/13444/diff/
>
>
> Testing
> -------
>
> All tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/#review25124
-----------------------------------------------------------
Ship it!
Please file a backward compatibility jira, we need to ensure that before we make the new release.
- Kishore Gopalakrishna
On Aug. 10, 2013, 1:12 a.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13444/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 1:12 a.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-166
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
>
> 1. Any issues with backward compatibility
> 2. Naming convention issues
> 3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
>
>
> Diffs
> -----
>
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
> helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java 7ba0dbe
> helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
> helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
> helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
> helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
> helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
> helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
> helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
> helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
> helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
> helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
> helix-core/src/main/java/org/apache/helix/tools/ZkLogCSVFormatter.java 1618eee
> helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
> helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
> helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
> helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
> helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleCalcStageCompatibility.java PRE-CREATION
> helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleStateCalcStage.java effea2c
> helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java c0b6528
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
> helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java df32c4e
> helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
> helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
> helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
> helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
> helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java 4e52444
> helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
> helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java 403864a
> helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
> helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
> recipes/distributed-lock-manager/README.md fdba382
> recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
> recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
> recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
> recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
>
> Diff: https://reviews.apache.org/r/13444/diff/
>
>
> Testing
> -------
>
> All tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/
-----------------------------------------------------------
(Updated Aug. 10, 2013, 1:12 a.m.)
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-166
Repository: helix-git
Description
-------
Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
1. Any issues with backward compatibility
2. Naming convention issues
3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
Diffs (updated)
-----
helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java 7ba0dbe
helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
helix-core/src/main/java/org/apache/helix/tools/ZkLogCSVFormatter.java 1618eee
helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleCalcStageCompatibility.java PRE-CREATION
helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleStateCalcStage.java effea2c
helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java c0b6528
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java df32c4e
helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
helix-core/src/test/java/org/apache/helix/integration/TestRenamePartition.java 4e52444
helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java 403864a
helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
recipes/distributed-lock-manager/README.md fdba382
recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
Diff: https://reviews.apache.org/r/13444/diff/
Testing
-------
All tests pass locally.
Thanks,
Kanak Biscuitwala
Re: Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
> On Aug. 9, 2013, 8:18 p.m., Kishore Gopalakrishna wrote:
> > helix-core/src/main/java/org/apache/helix/model/IdealState.java, line 365
> > <https://reviews.apache.org/r/13444/diff/1/?file=339217#file339217line365>
> >
> > rename to normalizeRebalancerMode or something like that. avoid having logic in get methods.
> >
> > same applies to getModeFromRebalancerMode
> >
> > dont we need a mode for pluggable/user defined
Done
> On Aug. 9, 2013, 8:18 p.m., Kishore Gopalakrishna wrote:
> > helix-core/src/main/java/org/apache/helix/model/IdealState.java, line 60
> > <https://reviews.apache.org/r/13444/diff/1/?file=339217#file339217line60>
> >
> > rename it to RebalanceMode
> >
Done
> On Aug. 9, 2013, 8:18 p.m., Kishore Gopalakrishna wrote:
> > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java, line 769
> > <https://reviews.apache.org/r/13444/diff/1/?file=339216#file339216line769>
> >
> > can we rename this to RebalancerMode ?
Done
> On Aug. 9, 2013, 8:18 p.m., Kishore Gopalakrishna wrote:
> > helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java, line 45
> > <https://reviews.apache.org/r/13444/diff/1/?file=339214#file339214line45>
> >
> > what about pluggable/user defined.
Added this option. It's a little bit of extra work before we can start using it, for which I've created a separate Jira.
- Kanak
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/#review24939
-----------------------------------------------------------
On Aug. 9, 2013, 5:24 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13444/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:24 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-166
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
>
> 1. Any issues with backward compatibility
> 2. Naming convention issues
> 3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
>
>
> Diffs
> -----
>
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
> helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
> helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
> helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
> helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
> helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
> helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
> helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
> helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
> helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
> helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
> helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
> helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
> helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
> helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
> helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
> helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
> helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
> helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
> helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
> helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
> helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
> helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
> recipes/distributed-lock-manager/README.md fdba382
> recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
> recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
> recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
> recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
>
> Diff: https://reviews.apache.org/r/13444/diff/
>
>
> Testing
> -------
>
> All tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 13444: [HELIX-166] Rename modes to auto, semi-auto, custom
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13444/#review24939
-----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java
<https://reviews.apache.org/r/13444/#comment49098>
what about pluggable/user defined.
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
<https://reviews.apache.org/r/13444/#comment49099>
can we rename this to RebalancerMode ?
helix-core/src/main/java/org/apache/helix/model/IdealState.java
<https://reviews.apache.org/r/13444/#comment49100>
rename it to RebalanceMode
helix-core/src/main/java/org/apache/helix/model/IdealState.java
<https://reviews.apache.org/r/13444/#comment49101>
rename to normalizeRebalancerMode or something like that. avoid having logic in get methods.
same applies to getModeFromRebalancerMode
dont we need a mode for pluggable/user defined
- Kishore Gopalakrishna
On Aug. 9, 2013, 5:24 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13444/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:24 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-166
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-166. The old names (AUTO_REBALANCE, AUTO, and CUSTOMIZED) were unclear to people who use HELIX. Thus, this change more clearly conveys which of the automatic modes actually does more. To maintain backward compatibility, the strategy is to deserialize the new field if either the new mode type or the new mode type is present, and to serialize both the new and old mode types. This is a pretty large change, and even though I checked for references and appearances of the old names, I may have missed something. Definitely let me know if you notice one or more of the following:
>
> 1. Any issues with backward compatibility
> 2. Naming convention issues
> 3. Other changes to more rigidly enforce the use of these new names, while accepting the old ones from old components.
>
>
> Diffs
> -----
>
> helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceGroupsResource.java dbbf0a1
> helix-core/src/main/java/org/apache/helix/HelixAdmin.java 5cd9a13
> helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java aca0e74
> helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java f013937
> helix-core/src/main/java/org/apache/helix/examples/IdealStateBuilderExample.java c516d39
> helix-core/src/main/java/org/apache/helix/examples/IdealStateExample.java f98199d
> helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java 1a5609b
> helix-core/src/main/java/org/apache/helix/model/IdealState.java 800477d
> helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java d3e7120
> helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java 15638e3
> helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java e75b7ac
> helix-core/src/main/java/org/apache/helix/model/builder/IdealStateBuilder.java 2877c74
> helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java d92b92f
> helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java 4260e87
> helix-core/src/test/java/org/apache/helix/TestHelper.java 6516138
> helix-core/src/test/java/org/apache/helix/TestZnodeModify.java 35ab5f0
> helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java 14d8892
> helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java af98620
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalance.java ea860c7
> helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java f26a867
> helix-core/src/test/java/org/apache/helix/integration/TestDisable.java f154007
> helix-core/src/test/java/org/apache/helix/integration/TestDriver.java 74b3bdc
> helix-core/src/test/java/org/apache/helix/integration/TestInstanceAutoJoin.java c9970e5
> helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java f742a74
> helix-core/src/test/java/org/apache/helix/integration/TestStartMultipleControllersWithSameName.java 27e6bdb
> helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java 0c261e2
> helix-core/src/test/java/org/apache/helix/model/TestIdealState.java 89b02ad
> helix-core/src/test/java/org/apache/helix/model/builder/TestIdealStateBuilder.java cdb7867
> recipes/distributed-lock-manager/README.md fdba382
> recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockManagerDemo.java 11cfdaf
> recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/SetupConsumerCluster.java 93aadb4
> recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/SetupCluster.java 77cc2f9
> recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskCluster.java c49659e
>
> Diff: https://reviews.apache.org/r/13444/diff/
>
>
> Testing
> -------
>
> All tests pass locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>