[GitHub] [pinot] shenyu0127 commented on a diff in pull request #11078: Column filter operators NULL support.

["shenyu0127 (via GitHub)" <gi...@apache.org>]

shenyu0127 commented on code in PR #11078:
URL: https://github.com/apache/pinot/pull/11078#discussion_r1275660929


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/BaseColumnFilterOperator.java:
##########
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.filter;
+
+import java.util.Arrays;
+import org.apache.pinot.core.common.BlockDocIdSet;
+import org.apache.pinot.core.operator.docidsets.AndDocIdSet;
+import org.apache.pinot.core.operator.docidsets.BitmapDocIdSet;
+import org.apache.pinot.core.query.request.context.QueryContext;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.segment.spi.index.reader.NullValueVectorReader;
+import org.roaringbitmap.buffer.ImmutableRoaringBitmap;
+
+
+public abstract class BaseColumnFilterOperator extends BaseFilterOperator {
+  protected final QueryContext _queryContext;
+  protected final DataSource _dataSource;
+
+  protected BaseColumnFilterOperator(QueryContext queryContext, DataSource dataSource, int numDocs) {
+    super(numDocs, queryContext.isNullHandlingEnabled());
+    _queryContext = queryContext;
+    _dataSource = dataSource;
+  }
+
+  protected abstract BlockDocIdSet getNextBlockWithoutNullHandling();
+
+  @Override
+  protected BlockDocIdSet getTrues() {
+    if (_nullHandlingEnabled) {
+      ImmutableRoaringBitmap nullBitmap = getNullBitmap();
+      if (nullBitmap != null && !nullBitmap.isEmpty()) {
+        return excludeNulls(getNextBlockWithoutNullHandling(), nullBitmap);
+      }
+    }
+    return getNextBlockWithoutNullHandling();
+  }
+
+
+  @Override
+  protected BlockDocIdSet getNulls() {
+    return new BitmapDocIdSet(getNullBitmap(), _numDocs);

Review Comment:
   Good catch.
   
   Fixed the bug and added a unit test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org