You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "mintsweet (via GitHub)" <gi...@apache.org> on 2023/05/31 07:17:29 UTC

[GitHub] [incubator-devlake] mintsweet opened a new pull request, #5327: fix: migration id defined error

mintsweet opened a new pull request, #5327:
URL: https://github.com/apache/incubator-devlake/pull/5327

   ### Summary
   Migration id defined error.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #5327: fix: migration id defined error

Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #5327:
URL: https://github.com/apache/incubator-devlake/pull/5327#discussion_r1211199958


##########
backend/plugins/bitbucket/models/migrationscripts/20230322_add_connection_id_to_transformation_rules.go:
##########
@@ -40,6 +40,10 @@ func (transformationRule20230322) TableName() string {
 	return "_tool_bitbucket_transformation_rules"
 }
 
+func (repo20230322) TableName() string {

Review Comment:
   @klesh 这样特别看下改对没有~跑着是没问题



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #5327: fix: migration id defined error

Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #5327:
URL: https://github.com/apache/incubator-devlake/pull/5327#discussion_r1211199958


##########
backend/plugins/bitbucket/models/migrationscripts/20230322_add_connection_id_to_transformation_rules.go:
##########
@@ -40,6 +40,10 @@ func (transformationRule20230322) TableName() string {
 	return "_tool_bitbucket_transformation_rules"
 }
 
+func (repo20230322) TableName() string {

Review Comment:
   @klesh Take a special look here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] mintsweet merged pull request #5327: fix: migration id defined error

Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet merged PR #5327:
URL: https://github.com/apache/incubator-devlake/pull/5327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org