You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/02 01:35:12 UTC
[GitHub] [incubator-doris] Gabriel39 commented on a diff in pull request #9915: [feature](compaction) add some optimize for compaction
Gabriel39 commented on code in PR #9915:
URL: https://github.com/apache/incubator-doris/pull/9915#discussion_r887425174
##########
be/src/olap/olap_server.cpp:
##########
@@ -304,6 +309,46 @@ void StorageEngine::_tablet_checkpoint_callback(const std::vector<DataDir*>& dat
} while (!_stop_background_threads_latch.wait_for(std::chrono::seconds(interval)));
}
+void StorageEngine::_adjust_compaction_thread_num() {
+ if (_base_compaction_thread_pool->max_threads() != config::max_base_compaction_threads) {
+ int old_max_threads = _base_compaction_thread_pool->max_threads();
+ Status status =
+ _base_compaction_thread_pool->set_max_threads(config::max_base_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update base compaction thread pool max_threads from " << old_max_threads
+ << " to " << config::max_base_compaction_threads;
+ }
+ }
+ if (_base_compaction_thread_pool->min_threads() != config::max_base_compaction_threads) {
+ int old_min_threads = _base_compaction_thread_pool->min_threads();
+ Status status =
+ _base_compaction_thread_pool->set_min_threads(config::max_base_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update base compaction thread pool min_threads from " << old_min_threads
+ << " to " << config::max_base_compaction_threads;
+ }
+ }
+
+ if (_cumu_compaction_thread_pool->max_threads() != config::max_cumu_compaction_threads) {
+ int old_max_threads = _cumu_compaction_thread_pool->max_threads();
+ Status status =
+ _cumu_compaction_thread_pool->set_max_threads(config::max_cumu_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update cumu compaction thread pool max_threads from " << old_max_threads
Review Comment:
Change to debug level log?
##########
be/src/olap/compaction.cpp:
##########
@@ -158,6 +158,8 @@ Status Compaction::do_compaction_impl(int64_t permits) {
<< ". tablet=" << _tablet->full_name() << ", output_version=" << _output_version
<< ", current_max_version=" << current_max_version
<< ", disk=" << _tablet->data_dir()->path() << ", segments=" << segments_num
+ << ", input_row_num=" << _input_row_num
+ << ", output_row_num=" << _output_rowset->num_rows()
Review Comment:
Should we also print filtered rows and merged rows?
##########
be/src/olap/olap_server.cpp:
##########
@@ -304,6 +309,46 @@ void StorageEngine::_tablet_checkpoint_callback(const std::vector<DataDir*>& dat
} while (!_stop_background_threads_latch.wait_for(std::chrono::seconds(interval)));
}
+void StorageEngine::_adjust_compaction_thread_num() {
+ if (_base_compaction_thread_pool->max_threads() != config::max_base_compaction_threads) {
+ int old_max_threads = _base_compaction_thread_pool->max_threads();
+ Status status =
+ _base_compaction_thread_pool->set_max_threads(config::max_base_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update base compaction thread pool max_threads from " << old_max_threads
+ << " to " << config::max_base_compaction_threads;
+ }
+ }
+ if (_base_compaction_thread_pool->min_threads() != config::max_base_compaction_threads) {
+ int old_min_threads = _base_compaction_thread_pool->min_threads();
+ Status status =
+ _base_compaction_thread_pool->set_min_threads(config::max_base_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update base compaction thread pool min_threads from " << old_min_threads
+ << " to " << config::max_base_compaction_threads;
+ }
+ }
+
+ if (_cumu_compaction_thread_pool->max_threads() != config::max_cumu_compaction_threads) {
+ int old_max_threads = _cumu_compaction_thread_pool->max_threads();
+ Status status =
+ _cumu_compaction_thread_pool->set_max_threads(config::max_cumu_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update cumu compaction thread pool max_threads from " << old_max_threads
+ << " to " << config::max_cumu_compaction_threads;
+ }
+ }
+ if (_cumu_compaction_thread_pool->min_threads() != config::max_cumu_compaction_threads) {
+ int old_min_threads = _cumu_compaction_thread_pool->min_threads();
+ Status status =
+ _cumu_compaction_thread_pool->set_min_threads(config::max_cumu_compaction_threads);
+ if (status.ok()) {
+ LOG(INFO) << "update cumu compaction thread pool min_threads from " << old_min_threads
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org