[GitHub] [pulsar] gaoran10 commented on a change in pull request #9667: [Compression] Fix ByteBuffer allocate error in the AirliftUtils

[GitBox <gi...@apache.org>]

gaoran10 commented on a change in pull request #9667:
URL: https://github.com/apache/pulsar/pull/9667#discussion_r579992634



##########
File path: pulsar-common/src/test/java/org/apache/pulsar/common/compression/CompressorCodecTest.java
##########
@@ -54,10 +72,10 @@
         };
     }
 
-    @Test(dataProvider = "codec")
-    void testCompressDecompress(CompressionType type, String compressedText) throws IOException {
+    @Test(dataProvider = "codecAndText")
+    void testCompressDecompress(CompressionType type, String sourceText) throws IOException {

Review comment:
       The compressed text param is not useful for this test, so I change the param from `compressedText` to `sourceText`, the purpose is to test complex text and no-repeated text, the complex text is used for the original test, the no duplicate text is used to verify this fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org