[GitHub] [airflow] pmalafosse commented on pull request #17141: ECSOperator / pass context to self.xcom_pull as it was missing (when using reattach)

[GitBox <gi...@apache.org>]

pmalafosse commented on pull request #17141:
URL: https://github.com/apache/airflow/pull/17141#issuecomment-884361263


   > Nice catch, shows how easily mocking in tests can be fraught (i.e. in this case missing the assert that context was provided). I'm curious how this got past manual testing though.
   
   this happened because in my manual testing I was using a previous version I had locally before a refactor :
   `context["ti"].xcom_pull(task_ids=..., key=...)` to 
   
   ```self.xcom_pull(
               context,
               task_ids=...,
               key=...,
           )
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org