You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/03/12 21:33:35 UTC
[GitHub] [geode] nonbinaryprogrammer opened a new pull request #6131: GEODE-9032: support SLOWLOG command
nonbinaryprogrammer opened a new pull request #6131:
URL: https://github.com/apache/geode/pull/6131
- update documentation to show SLOWLOG as a supported command
- move SLOWLOG to supported commands list in RedisCommandTypes
- update supported commands test
- did not add any new tests because it was already very well tested.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbey37 commented on a change in pull request #6131: GEODE-9032: support SLOWLOG command
Posted by GitBox <gi...@apache.org>.
sabbey37 commented on a change in pull request #6131:
URL: https://github.com/apache/geode/pull/6131#discussion_r594359786
##########
File path: geode-redis/README.md
##########
@@ -183,30 +183,30 @@ start server \
| HVALS | SINTER | CLIENT ID |
| INCR | SINTERSTORE | CLIENT KILL |
| INCRBY | SISMEMBER | CLIENT LIST |
-| INCRBYFLOAT | SLOWLOG | CLIENT PAUSE |
-| KEYS | SMOVE | CLIENT REPLY |
-| MGET | SPOP | CLIENT SETNAME |
-| PERSIST | SRANDMEMBER | CLIENT TRACKING |
-| PEXPIRE | SSCAN | CLIENT UNBLOCK |
-| PEXPIREAT | SUNION | CLUSTER ADDSLOTS |
-| PING | SUNIONSTORE | CLUSTER BUMPEPOCH |
-| PSUBSCRIBE | TIME | CLUSTER COUNT-FAILURE-REPORTS |
-| PTTL | UNLINK [1] | CLUSTER COUNTKEYSINSLOT |
+| INCRBYFLOAT | SMOVE | CLIENT PAUSE |
+| KEYS | SPOP | CLIENT REPLY |
+| MGET | SRANDMEMBER | CLIENT SETNAME |
+| PERSIST | SSCAN | CLIENT TRACKING |
+| PEXPIRE | SUNION | CLIENT UNBLOCK |
+| PEXPIREAT | SUNIONSTORE | CLUSTER ADDSLOTS |
+| PING | TIME | CLUSTER BUMPEPOCH |
+| PSUBSCRIBE | UNLINK [1] | CLUSTER COUNT-FAILURE-REPORTS |
+| PTTL | | CLUSTER COUNTKEYSINSLOT |
| PUBLISH | | CLUSTER DELSLOTS |
| PUNSUBSCRIBE | | CLUSTER FAILOVER |
| QUIT | | CLUSTER FLUSHSLOTS |
| RENAME | | CLUSTER FORGET |
| SADD | | CLUSTER GETKEYSINSLOT |
| SET | | CLUSTER INFO |
| SETNX | | CLUSTER KEYSLOT |
-| SMEMBERS | | CLUSTER MEET |
-| SREM | | CLUSTER MYID |
-| STRLEN | | CLUSTER NODES |
-| SUBSCRIBE | | CLUSTER REPLICAS |
-| TTL | | CLUSTER REPLICATE |
-| TYPE | | CLUSTER RESET |
-| UNSUBSCRIBE | | CLUSTER SAVECONFIG |
-| | | CLUSTER SET-CONFIG-EPOCH |
+| SLOWLOG | | CLUSTER MEET |
Review comment:
Maybe we could put a number next to this one like we did for `UNLINK` and put a footer note at the bottom of the file that it's a NoOp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nonbinaryprogrammer merged pull request #6131: GEODE-9032: support SLOWLOG command
Posted by GitBox <gi...@apache.org>.
nonbinaryprogrammer merged pull request #6131:
URL: https://github.com/apache/geode/pull/6131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org