You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "vignesh-manel (via GitHub)" <gi...@apache.org> on 2023/09/17 13:37:57 UTC
[GitHub] [camel] vignesh-manel opened a new pull request, #11429: Camel 17315: Added AWS Redshift Data Component
vignesh-manel opened a new pull request, #11429:
URL: https://github.com/apache/camel/pull/11429
# Description
Added AWS Redshift Data component
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] squakez commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1725848409
Thanks. I'm restarting the check to verify if it solved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #11429:
URL: https://github.com/apache/camel/pull/11429#discussion_r1328326080
##########
components/camel-aws/camel-aws2-redshift/src/test/java/org/apache/camel/component/aws2/redshift/data/AmazonRedshiftDataClientMock.java:
##########
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.aws2.redshift.data;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import software.amazon.awssdk.services.redshiftdata.RedshiftDataClient;
+import software.amazon.awssdk.services.redshiftdata.model.*;
Review Comment:
Please don't use * imports
##########
components/camel-aws/camel-aws2-redshift/src/test/java/org/apache/camel/component/aws2/redshift/data/RedshiftData2ProducerSpringTest.java:
##########
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.aws2.redshift.data;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.camel.EndpointInject;
+import org.apache.camel.Exchange;
+import org.apache.camel.Processor;
+import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.test.spring.junit5.CamelSpringTestSupport;
+import org.junit.jupiter.api.Test;
+import org.springframework.context.support.ClassPathXmlApplicationContext;
+import software.amazon.awssdk.services.redshiftdata.model.*;
Review Comment:
Ditto
##########
components/camel-aws/camel-aws2-redshift/pom.xml:
##########
@@ -0,0 +1,89 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.camel</groupId>
+ <relativePath>../../pom.xml</relativePath>
+ <artifactId>components</artifactId>
+ <version>4.1.0-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>camel-aws2-redshift</artifactId>
+ <packaging>jar</packaging>
+
+ <name>Camel :: AWS Redshift Data</name>
+ <description>A Camel Amazon Web Services Redshift Data Component</description>
+
+ <properties>
+ <camel.surefire.forkTimeout>1200</camel.surefire.forkTimeout>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-support</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-health</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>redshiftdata</artifactId>
+ <version>${aws-java-sdk2-version}</version>
+ </dependency>
+ <dependency>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>apache-client</artifactId>
+ <version>${aws-java-sdk2-version}</version>
+ </dependency>
+
+ <!-- for testing -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
+ <artifactId>camel-test-spring-junit5</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- test infra -->
+ <dependency>
+ <groupId>org.apache.camel</groupId>
Review Comment:
As far as I see we are not testing against localstack, so this dependency could be removed.
##########
components/camel-aws/camel-aws2-redshift/src/test/java/org/apache/camel/component/aws2/redshift/data/RedshiftData2ProducerTest.java:
##########
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.aws2.redshift.data;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.camel.BindToRegistry;
+import org.apache.camel.EndpointInject;
+import org.apache.camel.Exchange;
+import org.apache.camel.Processor;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.test.junit5.CamelTestSupport;
+import org.junit.jupiter.api.Test;
+import software.amazon.awssdk.services.redshiftdata.model.*;
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel closed pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel closed pull request #11429: Camel 17315 : Added AWS Redshift Data Component
URL: https://github.com/apache/camel/pull/11429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel merged pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel merged PR #11429:
URL: https://github.com/apache/camel/pull/11429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11429: Camel 17315: Added AWS Redshift Data Component
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1722479641
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1722486250
Closing this, as @oscerd has already worked on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1723644724
Can this be merged? As it's approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1722487939
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1725832436
@davsclaus / @oscerd Can you please check this PR for above issue https://github.com/apache/camel/pull/11469
FYI @squakez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] squakez commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1725632495
It seems this PR merge has some problem with website generation: https://github.com/apache/camel-website/actions/runs/6233892387/job/16920007785?pr=1062
```
➤ YN0000: [build:antora ] [build:antora-perf] [10:10:25.144] WARN (asciidoctor):
➤ YN0000: [build:antora ] [build:antora-perf] file: docs/components/modules/ROOT/pages/aws2-redshift-data-component.adoc
➤ YN0000: [build:antora ] [build:antora-perf] source: https://github.com/apache/camel.git (refname: main, start path: docs/components)
➤ YN0000: [build:antora ] [build:antora-perf] msg: {
➤ YN0000: [build:antora ] [build:antora-perf] "msg": "Target spring-boot:example$json/aws2-redshift-data.json not found",
➤ YN0000: [build:antora ] [build:antora-perf] "useId": 7,
➤ YN0000: [build:antora ] [build:antora-perf] "jsonpath": "jsonpathcount$"
➤ YN0000: [build:antora ] [build:antora-perf] }
➤ YN0000: [build:antora ] ERROR: "build:antora-perf" exited with 1.
```
Can you please have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1723652746
Sure, go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] vignesh-manel commented on pull request #11429: Camel 17315 : Added AWS Redshift Data Component
Posted by "vignesh-manel (via GitHub)" <gi...@apache.org>.
vignesh-manel commented on PR #11429:
URL: https://github.com/apache/camel/pull/11429#issuecomment-1723533377
@oscerd Update code as per the comments, please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org