You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@tapestry.apache.org by George Christman <gc...@cardaddy.com> on 2014/03/17 15:18:50 UTC

How to handle form warnings?

Hi Guys, A new requirement has come up where I need to provide validation
warnings to the end user on form submission. As long as the user clicks
okay to the warning, they can continue on with the save. My current design
is as followed.

1. Submit ajax form "timesheet object"
2. Handle form validation errors server side and return to errors to UI
3. If no validation errors occur, process warning logic.
4. If warnings exist, temporarily persist timesheet object to
timesheetHolder obj
5. Return warnings to ui via ajax for the user to OK and acknowledge.
6. On warning submit, grab persisted timesheetHolder obj and copy property
values to timesheet object.
7. Save timesheet object.


Although in theory his should work, I continue to get the following
hibernate exception.

"a different object with the same identifier value was already associated
with the session"

Backend code looks something like this.

warning.java

@PageActivationContext
@Property
private TimeSheetEntity timesheet;

@Persist(PersistenceConstants.FLASH)
private TimeSheetEntity timeSheetHolder;

@Property
private WarningExample warningExample;

@InjectComponent
private Zone formZone, warningZone;

void onActivate() {
        if (timesheet== null) {
            timesheet= new TimeSheetEntity();
        }
 }

Object onValidateFromForm() throws IllegalAccessException,
InvocationTargetException {
        if (timesheet.getName() == null) {
            form.recordError("fix field");
        }

        if (!form.getHasErrors()) {
            timeSheetHolder = new TimeSheetEntity();
            BeanUtils.copyProperties(timeSheetHolder , timesheet);
            hasWarning = true;
        }

        if (hasWarning || form.getHasErrors()) {
            return formZone.getBody();
        }
        return null;
    }

@CommitAfter
    Object onSuccessFromForm() throws IllegalAccessException,
InvocationTargetException {

        if (timeSheetHolder != null) {
            BeanUtils.copyProperties(timesheet, timeSheetHolder);;
        }

        session.saveOrUpdate(timeSheetHolder);
        return linkSource.createPageRenderLinkWithContext(TimeSheet.class,
timesheet.getId());
    }


Warning form

Object onValidateFromWarningForm() {
        if (!warningExample.hasWarning) {
            warningForm.recordError("Form error");
            return warningZone.getBody();
        }

        return null;
    }

    Object onSuccessFromWarningForm() throws IllegalAccessException,
InvocationTargetException {
        return onSuccessFromForm();
    }

    public class WarningExample {

        private boolean hasWarning;

        public boolean isHasWarning() {
            return hasWarning;
        }

        public void setHasWarning(boolean hasWarning) {
            this.hasWarning = hasWarning;
        }
    }


warning.tml


<html t:type="layout" title="this is a warning" xmlns:t="
http://tapestry.apache.org/schema/tapestry_5_1_0.xsd"
xmlns:p="tapestry:parameter">
    <div t:type="zone" t:id="formZone" id="formZone">
        <t:form t:id="form" zone="formZone">
            <t:errors/>
            <div class="form-group">
                <t:Label class="control-label" for="warning"/>
                <t:TextField t:id="warning" value="warning.name"/>
            </div>
            <t:submit t:id="save" value="save"/>
        </t:form>

        <t:if test="hasWarning">
            <div t:type="zone" t:id="warningZone" id="warningZone">
                <t:form t:id="warningForm" zone="warningZone">
                    <t:errors/>
                    <t:checkbox t:id="hasWarning"
value="warningExample.hasWarning"/>Notice 1
                    <t:submit t:id="saveWarning" value="save warning"/>
                </t:form>
            </div>
        </t:if>
    </div>
</html>



Has anybody done anything like this or have a better approach? Perhaps
there is a work around to my bug as well. Please let me know if anybody has
a suggestions.

Thanks

Re: How to handle form warnings?

Posted by Thiago H de Paula Figueiredo <th...@gmail.com>.

On Mon, 17 Mar 2014 12:31:31 -0300, George Christman  
<gc...@cardaddy.com> wrote:

> Hi Thiago, I'm aware the hibernate piece is unrelated, however what I'm
> asking is storing my object in the user session the correct approach?

I wouldn't say it's the ideal solution, but I'd consider it a valid one.

> I'm really wondering if I'm using Tapestry properly to produce warnings.

As someone already said, wrap the form inside a Zone, have your form  
update this zone. Use the Errors component to show the validation errors.  
That's what I'd do.

> I don't want to just patch the issue with hibernate .merge if I'm not  
> doing
> something correctly with Tapestry first.

Session.merge() is actually more recommended than saveOrUpdate() anyway. I  
learned this the hard way. merge() completely solves the "a different  
object with the same identifier value was already associated with the  
session" problem.

-- 
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
For additional commands, e-mail: users-help@tapestry.apache.org

Re: How to handle form warnings?

Posted by George Christman <gc...@cardaddy.com>.

Hi Thiago, I'm aware the hibernate piece is unrelated, however what I'm
asking is storing my object in the user session the correct approach? I'm
really wondering if I'm using Tapestry properly to produce warnings. I
don't want to just patch the issue with hibernate .merge if I'm not doing
something correctly with Tapestry first.

On Mon, Mar 17, 2014 at 11:10 AM, Thiago H de Paula Figueiredo <
thiagohp@gmail.com> wrote:

> On Mon, 17 Mar 2014 11:18:50 -0300, George Christman <
> gchristman@cardaddy.com> wrote:
>
>  Hi Guys,
>>
>
> Hi!
>
>
>  Although in theory his should work, I continue to get the following
>> hibernate exception.
>>
>> "a different object with the same identifier value was already associated
>> with the session"
>>
>
> This is unrelated to Tapestry.
>
>          session.saveOrUpdate(timeSheetHolder);
>>
>
> Try this instead: timeSheetHolder = session.merge(timeSheetHolder);
>
>
> --
> Thiago H. de Paula Figueiredo
> Tapestry, Java and Hibernate consultant and developer
> http://machina.com.br
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: users-help@tapestry.apache.org
>
>

-- 
George Christman
www.CarDaddy.com
P.O. Box 735
Johnstown, New York