[GitHub] [arrow] kou commented on a diff in pull request #36584: MINOR: [C++] Cleanup FindgRPCAlt

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #36584:
URL: https://github.com/apache/arrow/pull/36584#discussion_r1257681400


##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -36,7 +36,7 @@ if(GRPCPP_PC_FOUND)
   # gRPC's pkg-config file neglects to specify pthreads.
   find_package(Threads REQUIRED)
   if(ARROW_GRPC_USE_SHARED)
-    set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES} Threads::Threads)
+    list(APPEND GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})

Review Comment:
   Could you use `set()` instead of `list(APPEND)` because we don't use any pre-defined `GRPCPP_LINK_LIBRARIES` here?
   
   ```suggestion
       set(GRPCPP_LINK_LIBRARIES ${GRPCPP_PC_LINK_LIBRARIES})
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org