general/2583: Incomplete conversion from perror to ap_log_error

[David MacKenzie <dj...@uu.net>]

>Number:         2583
>Category:       general
>Synopsis:       Incomplete conversion from perror to ap_log_error
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Fri Jul 10 05:20:00 PDT 1998
>Last-Modified:
>Originator:     djm@uu.net
>Organization:
apache
>Release:        1.3.0
>Environment:
any
>Description:
In main/http_main.c there are still some calls to perror and fprintf(stderr,
in the midst of calls to ap_log_error.  For example, after getpeername
and getsockname calls.  Those error messages may never be seen, as a result,
and they don't get the benefits of the timestamp mark and log level filtering.
There are other examples in http_log.c, util.c, etc.

Currently I am trying to debug a problem with some of our servers logging
incomplete IP addresses occasionally (just one octet instead of four), so knowing what
happened with getpeername is important.
>How-To-Repeat:
egrep 'perror|stderr' src/*/*.c

>Fix:
Finish the process of converting to using ap_log_error.
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]