You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/19 18:56:00 UTC
[GitHub] [netbeans-mavenutils-nb-repository-plugin] ebarboni opened a new
pull request #3: NETBEANSINFRA-12 remove libraries that have maven
coordinate sha1 checked
ebarboni opened a new pull request #3: NETBEANSINFRA-12 remove libraries that have maven coordinate sha1 checked
URL: https://github.com/apache/netbeans-mavenutils-nb-repository-plugin/pull/3
libraries will use their coordinate instead.
This is working for org.netbeans.html artefacts.
I did a change to use only whitelisted sha1 libraries coordinates.
I have an issue with maven.embedder we use a ziped maven that we unzip later that gives jar that we have not whitelisted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nb-repository-plugin] ebarboni commented on a
change in pull request #3: NETBEANSINFRA-12 remove libraries that have
maven coordinate sha1 checked
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #3: NETBEANSINFRA-12 remove libraries that have maven coordinate sha1 checked
URL: https://github.com/apache/netbeans-mavenutils-nb-repository-plugin/pull/3#discussion_r395502945
##########
File path: src/main/java/org/apache/netbeans/nbm/repository/PopulateRepositoryMojo.java
##########
@@ -389,16 +389,21 @@ else if ( skipLocalInstall )
String version = forcedVersion == null ? examinator.getSpecVersion() : forcedVersion;
String group = groupIdPrefix + ( examinator.isOsgiBundle() ? GROUP_EXTERNAL : examinator.hasPublicPackages() ? GROUP_API : GROUP_IMPL );
Artifact art = createArtifact( artifact, version, group );
+ ModuleWrapper wr = new ModuleWrapper( artifact, version, group, examinator, module, false );
if ( examinator.isOsgiBundle() )
{
Dependency dep = findExternal( module );
- if ( dep != null )
+ if ( dep != null )
{
+
+ art = createArtifact( artifact, dep.getVersion(), dep.getGroupId() );
+ group = dep.getGroupId();
+ version = dep.getVersion();
+ wr = new ModuleWrapper( artifact, version, group, examinator, module , true );
// XXX use those coords instead of publishing this
// (for now all bundles are from Orbit, which does not publish to Central, or specially built)
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nb-repository-plugin] ebarboni merged pull
request #3: NETBEANSINFRA-12 remove libraries that have maven coordinate
sha1 checked
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #3: NETBEANSINFRA-12 remove libraries that have maven coordinate sha1 checked
URL: https://github.com/apache/netbeans-mavenutils-nb-repository-plugin/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nb-repository-plugin] JaroslavTulach commented
on a change in pull request #3: NETBEANSINFRA-12 remove libraries that have
maven coordinate sha1 checked
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3: NETBEANSINFRA-12 remove libraries that have maven coordinate sha1 checked
URL: https://github.com/apache/netbeans-mavenutils-nb-repository-plugin/pull/3#discussion_r395429131
##########
File path: src/main/java/org/apache/netbeans/nbm/repository/PopulateRepositoryMojo.java
##########
@@ -389,16 +389,21 @@ else if ( skipLocalInstall )
String version = forcedVersion == null ? examinator.getSpecVersion() : forcedVersion;
String group = groupIdPrefix + ( examinator.isOsgiBundle() ? GROUP_EXTERNAL : examinator.hasPublicPackages() ? GROUP_API : GROUP_IMPL );
Artifact art = createArtifact( artifact, version, group );
+ ModuleWrapper wr = new ModuleWrapper( artifact, version, group, examinator, module, false );
if ( examinator.isOsgiBundle() )
{
Dependency dep = findExternal( module );
- if ( dep != null )
+ if ( dep != null )
{
+
+ art = createArtifact( artifact, dep.getVersion(), dep.getGroupId() );
+ group = dep.getGroupId();
+ version = dep.getVersion();
+ wr = new ModuleWrapper( artifact, version, group, examinator, module , true );
// XXX use those coords instead of publishing this
// (for now all bundles are from Orbit, which does not publish to Central, or specially built)
Review comment:
You an possibly remove the comment now as the job will now _"use those coords instead of publishing this"_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists