You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/02/27 06:02:08 UTC
[PR] chore: Update Scala to 2.13.13 [incubator-pekko]
He-Pin opened a new pull request, #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155
Update Scala to 2.13.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#discussion_r1503903719
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -74,16 +74,19 @@ object PekkoDisciplinePlugin extends AutoPlugin {
"pekko-stream-tests-tck",
"pekko-testkit")
- val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,any:e"
+ lazy val defaultScalaOptions = Def.setting(CrossVersion.partialVersion(scalaVersion.value) match {
+ case Some((2, 12)) => "-Wconf:cat=unused-nowarn:s,any:e"
+ case _ => "-Wconf:cat=unused-nowarn:s,cat=lint-named-booleans:s,cat=other-shadowing:s,any:e"
Review Comment:
Possible, but then need to change a lot of code, And I think that can be done in a separated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#discussion_r1503925594
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -74,16 +74,19 @@ object PekkoDisciplinePlugin extends AutoPlugin {
"pekko-stream-tests-tck",
"pekko-testkit")
- val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,any:e"
+ lazy val defaultScalaOptions = Def.setting(CrossVersion.partialVersion(scalaVersion.value) match {
+ case Some((2, 12)) => "-Wconf:cat=unused-nowarn:s,any:e"
+ case _ => "-Wconf:cat=unused-nowarn:s,cat=lint-named-booleans:s,cat=other-shadowing:s,any:e"
Review Comment:
gotcha - maybe create an issue for it here for starters and refer to that from here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#discussion_r1503903719
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -74,16 +74,19 @@ object PekkoDisciplinePlugin extends AutoPlugin {
"pekko-stream-tests-tck",
"pekko-testkit")
- val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,any:e"
+ lazy val defaultScalaOptions = Def.setting(CrossVersion.partialVersion(scalaVersion.value) match {
+ case Some((2, 12)) => "-Wconf:cat=unused-nowarn:s,any:e"
+ case _ => "-Wconf:cat=unused-nowarn:s,cat=lint-named-booleans:s,cat=other-shadowing:s,any:e"
Review Comment:
Possible, but then need to change a lot of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#issuecomment-1965911638
CI check shows some compilation errors.
```
[02-27 06:55:56.144] [error] (osgi / Test / compileIncremental) Compilation failed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#discussion_r1503907778
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -74,16 +74,19 @@ object PekkoDisciplinePlugin extends AutoPlugin {
"pekko-stream-tests-tck",
"pekko-testkit")
- val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,any:e"
+ lazy val defaultScalaOptions = Def.setting(CrossVersion.partialVersion(scalaVersion.value) match {
+ case Some((2, 12)) => "-Wconf:cat=unused-nowarn:s,any:e"
+ case _ => "-Wconf:cat=unused-nowarn:s,cat=lint-named-booleans:s,cat=other-shadowing:s,any:e"
Review Comment:
some of the code that doesn't compile appears to be generated - I think we may need to skip this upgrade and report bugs to Scala team
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155#discussion_r1503890094
##########
project/PekkoDisciplinePlugin.scala:
##########
@@ -74,16 +74,19 @@ object PekkoDisciplinePlugin extends AutoPlugin {
"pekko-stream-tests-tck",
"pekko-testkit")
- val defaultScalaOptions = "-Wconf:cat=unused-nowarn:s,any:e"
+ lazy val defaultScalaOptions = Def.setting(CrossVersion.partialVersion(scalaVersion.value) match {
+ case Some((2, 12)) => "-Wconf:cat=unused-nowarn:s,any:e"
+ case _ => "-Wconf:cat=unused-nowarn:s,cat=lint-named-booleans:s,cat=other-shadowing:s,any:e"
Review Comment:
was it impossible to fix the warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update Scala to 2.13.13 [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1155:
URL: https://github.com/apache/incubator-pekko/pull/1155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org