You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/11 16:22:48 UTC
[GitHub] srowen commented on issue #23757: [SPARK-23408][SS][BRANCH-2.3]
Synchronize successive AddData actions in Streaming*JoinSuite
srowen commented on issue #23757: [SPARK-23408][SS][BRANCH-2.3] Synchronize successive AddData actions in Streaming*JoinSuite
URL: https://github.com/apache/spark/pull/23757#issuecomment-462391431
Just to make sure I understand the status:
This is a straight back-port of https://github.com/apache/spark/pull/20650/files?w=1 , and indeed it looks like the same change we see here with https://github.com/apache/spark/pull/23757/files?w=1 , OK. It can be merged first without other changes, pending tests?
Maybe someone can help me understand this. The diff at
https://github.com/apache/spark/pull/23757/files?w=1
looks pretty different from
https://github.com/apache/spark/pull/23757/files
I know the difference is supposed to be just whitespace in the diff, but the latter seems to show a much more significant reordering of code. I can't figure out what to make of it. Am I missing something obvious?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org