You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/02 14:58:13 UTC
[GitHub] [incubator-yunikorn-core] manirajv06 opened a new pull request #369: [YUNIKORN-935] Refactor resourcemanagercallback mock class
manirajv06 opened a new pull request #369:
URL: https://github.com/apache/incubator-yunikorn-core/pull/369
### What is this PR for?
Multiple implementations of ResourceManagerCallback interface in several test go files has been removed by introducing single common struct which implements ResourceManagerCallback interface
### What type of PR is it?
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-935
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #369: [YUNIKORN-935] Refactor resourcemanagercallback mock class
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #369:
URL: https://github.com/apache/incubator-yunikorn-core/pull/369#issuecomment-1028029272
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#369](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (beec2f2) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/0d3104c7ea0c024c0f3186dba528deeff7009d28?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0d3104c) will **decrease** coverage by `0.05%`.
> The diff coverage is `38.88%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 68.16% 68.10% -0.06%
==========================================
Files 64 65 +1
Lines 9036 9054 +18
==========================================
+ Hits 6159 6166 +7
- Misses 2640 2651 +11
Partials 237 237
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/tests/mock\_rm\_callback.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci90ZXN0cy9tb2NrX3JtX2NhbGxiYWNrLmdv) | `38.88% <38.88%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0d3104c...beec2f2](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/369?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #369: [YUNIKORN-935] Refactor resourcemanagercallback mock class
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #369:
URL: https://github.com/apache/incubator-yunikorn-core/pull/369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org