You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/01/31 19:40:28 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #8082: Listener TLS customization

Jackie-Jiang commented on a change in pull request #8082:
URL: https://github.com/apache/pinot/pull/8082#discussion_r796004459



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java
##########
@@ -167,24 +172,38 @@ private ListenerConfigUtil() {
     return listeners;
   }
 
-  private static ListenerConfig buildListenerConfig(PinotConfiguration config, String namespace, String protocol,
+  private static ListenerConfig buildListenerConfig(PinotConfiguration config, String namespace, String name,

Review comment:
       （minor) why changing the parameter from `protocol` to `name`? `protocol` seems more clear to me




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org