You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Earthson <gi...@git.apache.org> on 2015/11/12 05:24:07 UTC
[GitHub] spark pull request: https://issues.apache.org/jira/browse/SPARK-67...
GitHub user Earthson opened a pull request:
https://github.com/apache/spark/pull/9650
https://issues.apache.org/jira/browse/SPARK-6790
based on SPARK-6726.
I've implemented a common interface for PipelineStage read/write that only need Metadata(non-model pipeline stage).
If the API is OK, I could add other PipelineStage's read/write based on it:)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Earthson/spark SPARK-6727
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9650
----
commit bce0464b6045fc165baaed78635eaf7d13aa43af
Author: Earthson Lu <ea...@gmail.com>
Date: 2015-11-12T04:12:04Z
SPARK-6727 add HashingTF read/write
commit b3f26d6596b590bec02da0396ae2d6483f96345b
Author: Earthson Lu <ea...@gmail.com>
Date: 2015-11-12T04:13:24Z
Merge branch 'master' into SPARK-6727
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: https://issues.apache.org/jira/browse/SPARK-67...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9650#issuecomment-155994445
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6727][ML] Model export/import for spark...
Posted by Earthson <gi...@git.apache.org>.
Github user Earthson commented on the pull request:
https://github.com/apache/spark/pull/9650#issuecomment-156036519
I have an idea that may simplify the using DefaultParamsReader/Writer
```scala
/**
* Default Writable using DefaultParamsWriter
*/
@Experimental
@Since("1.6.0")
trait DefaultWritable extends Writable {
self: Params =>
override def write: Writer = new DefaultParamsWriter(self)
}
/**
* Default Readable using DefaultParamsReader
* @tparam T ML instance type
*/
@Experimental
@Since("1.6.0")
trait DefaultReadable[T] extends Readable[T] {
override def read: Reader[T] = new DefaultParamsReader[T]
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org