You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by km...@apache.org on 2007/10/14 23:31:00 UTC
svn commit: r584612 - in
/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne:
dba/frontbase/FrontBaseAdapter.java dba/frontbase/FrontBasePkGenerator.java
map/MapLoader.java
Author: kmenard
Date: Sun Oct 14 14:31:00 2007
New Revision: 584612
URL: http://svn.apache.org/viewvc?rev=584612&view=rev
Log:
Reduce number of newly allocated strings.
Modified:
cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBaseAdapter.java
cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBasePkGenerator.java
cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/map/MapLoader.java
Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBaseAdapter.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBaseAdapter.java?rev=584612&r1=584611&r2=584612&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBaseAdapter.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBaseAdapter.java Sun Oct 14 14:31:00 2007
@@ -140,14 +140,14 @@
if (at.getType() == Types.LONGVARCHAR) {
int len = at.getMaxLength() > 0 ? at.getMaxLength() : 1073741824;
- buf.append("(" + len + ")");
+ buf.append("(").append(len).append(")");
}
else if (at.getType() == Types.VARBINARY || at.getType() == Types.BINARY) {
// use a BIT column with size * 8
int len = at.getMaxLength() > 0 ? at.getMaxLength() : 1073741824;
len *= 8;
- buf.append("(" + len + ")");
+ buf.append("(").append(len).append(")");
}
else if (TypesMapping.supportsLength(at.getType())) {
int len = at.getMaxLength();
Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBasePkGenerator.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBasePkGenerator.java?rev=584612&r1=584611&r2=584612&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBasePkGenerator.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/dba/frontbase/FrontBasePkGenerator.java Sun Oct 14 14:31:00 2007
@@ -83,13 +83,13 @@
protected String pkCreateString(String entName) {
StringBuffer buf = new StringBuffer();
- buf.append("SET UNIQUE = 1000000 FOR \"" + entName + "\"");
+ buf.append("SET UNIQUE = 1000000 FOR \"").append(entName).append("\"");
return buf.toString();
}
protected String pkSelectString(String entName) {
StringBuffer buf = new StringBuffer();
- buf.append("SELECT UNIQUE FROM \"" + entName + "\"");
+ buf.append("SELECT UNIQUE FROM \"").append(entName).append("\"");
return buf.toString();
}
Modified: cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/map/MapLoader.java
URL: http://svn.apache.org/viewvc/cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/map/MapLoader.java?rev=584612&r1=584611&r2=584612&view=diff
==============================================================================
--- cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/map/MapLoader.java (original)
+++ cayenne/main/trunk/framework/cayenne-jdk1.4-unpublished/src/main/java/org/apache/cayenne/map/MapLoader.java Sun Oct 14 14:31:00 2007
@@ -1110,7 +1110,7 @@
for (int i = 0; i < atts.getLength(); i++) {
value = atts.getQName(i);
name = atts.getValue(i);
- sb.append("Name: " + name + "\tValue: " + value + "\n");
+ sb.append("Name: ").append(name).append("\tValue: ").append(value).append("\n");
}
return sb;
}