You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Mansoor (JIRA)" <de...@geronimo.apache.org> on 2006/04/06 08:26:44 UTC

[jira] Created: (GERONIMO-1813) When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory

When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory
--------------------------------------------------------------------------------------------------------------------------

         Key: GERONIMO-1813
         URL: http://issues.apache.org/jira/browse/GERONIMO-1813
     Project: Geronimo
        Type: Bug
    Security: public (Regular issues) 
  Components: Hot Deploy Dir  
    Versions: 1.1    
 Environment: Win2k , JDK 1.4.2
    Reporter: Mansoor
    Priority: Minor


Hi ,

Problem :
       When already an application module say (hello.war) is deployed (either by using manually or hot deploy procedure ) , And when some one try to hot deploy the same application with same or different name ( say hello.war | hello2.war | hello2 directory ) ,  the server throws an exception saying there exists already an application deployed , But doesn't delete the module ( hello.war | hello2.war |  hello2 directory)  from hot deploy directory .

Thus the next time the server starts , it tries to deploy the same module once again. 

Here i have a piece of code put into DirectoryHotDeployer.java  file , which can solve the above issue and also to some extend users can get clean picture.

Basically it deletes the asset from deploy directory ,which got failed to hot deploy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1813) When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory

Posted by "Mansoor (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1813?page=all ]

Mansoor updated GERONIMO-1813:
------------------------------

    Attachment: hotdeploy_patch1_06042006.txt

The patch basically deletes the asset from deploy directory ,which got failed to hot deploy successfully , this can also give the clear view to users of geronimo application server


> When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory
> --------------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1813
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1813
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: Hot Deploy Dir
>     Versions: 1.1
>  Environment: Win2k , JDK 1.4.2
>     Reporter: Mansoor
>     Priority: Minor
>  Attachments: hotdeploy_patch1_06042006.txt
>
> Hi ,
> Problem :
>        When already an application module say (hello.war) is deployed (either by using manually or hot deploy procedure ) , And when some one try to hot deploy the same application with same or different name ( say hello.war | hello2.war | hello2 directory ) ,  the server throws an exception saying there exists already an application deployed , But doesn't delete the module ( hello.war | hello2.war |  hello2 directory)  from hot deploy directory .
> Thus the next time the server starts , it tries to deploy the same module once again. 
> Here i have a piece of code put into DirectoryHotDeployer.java  file , which can solve the above issue and also to some extend users can get clean picture.
> Basically it deletes the asset from deploy directory ,which got failed to hot deploy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1813) When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory

Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1813?page=comments#action_12414977 ] 

Aaron Mulder commented on GERONIMO-1813:
----------------------------------------

This patch is OK, but I think there's a better way to handle it.

I think when we detect a new or updated file, we should calculate its module ID and see whether it's current'y deployed or not.  If it is deployed, we should redeploy, and if not, deploy.  That would help with both this case (bad deployment) and also if you deploy with the CLI and then copy a newer version into the hot deploy directory.

Thanks,
     Aaron


> When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory
> --------------------------------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1813
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1813
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>   Components: Hot Deploy Dir
>     Versions: 1.1
>  Environment: Win2k , JDK 1.4.2
>     Reporter: Mansoor
>     Priority: Minor
>  Attachments: hotdeploy_patch1_06042006.txt
>
> Hi ,
> Problem :
>        When already an application module say (hello.war) is deployed (either by using manually or hot deploy procedure ) , And when some one try to hot deploy the same application with same or different name ( say hello.war | hello2.war | hello2 directory ) ,  the server throws an exception saying there exists already an application deployed , But doesn't delete the module ( hello.war | hello2.war |  hello2 directory)  from hot deploy directory .
> Thus the next time the server starts , it tries to deploy the same module once again. 
> Here i have a piece of code put into DirectoryHotDeployer.java  file , which can solve the above issue and also to some extend users can get clean picture.
> Basically it deletes the asset from deploy directory ,which got failed to hot deploy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1813) When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory

Posted by "Matt Hogstrom (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1813?page=all ]

Matt Hogstrom closed GERONIMO-1813.
-----------------------------------

    Resolution: Fixed
      Assignee: Matt Hogstrom

Applied to trunk 
New Revision: 474972
Modified:
    geronimo/server/trunk/modules/geronimo-hot-deploy/src/main/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java

and branches/1.1

Sending        hot-deploy/project.xml
Sending        hot-deploy/src/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java
Transmitting file data ..
Committed revision 474983.

> When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-1813
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1813
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Hot Deploy Dir
>    Affects Versions: 1.1
>         Environment: Win2k , JDK 1.4.2
>            Reporter: Mansoor
>         Assigned To: Matt Hogstrom
>            Priority: Minor
>             Fix For: 1.1.x, 1.2
>
>         Attachments: hotdeploy_patch1_06042006.txt, hotdeploy_projectxml_06042006.txt
>
>
> Hi ,
> Problem :
>        When already an application module say (hello.war) is deployed (either by using manually or hot deploy procedure ) , And when some one try to hot deploy the same application with same or different name ( say hello.war | hello2.war | hello2 directory ) ,  the server throws an exception saying there exists already an application deployed , But doesn't delete the module ( hello.war | hello2.war |  hello2 directory)  from hot deploy directory .
> Thus the next time the server starts , it tries to deploy the same module once again. 
> Here i have a piece of code put into DirectoryHotDeployer.java  file , which can solve the above issue and also to some extend users can get clean picture.
> Basically it deletes the asset from deploy directory ,which got failed to hot deploy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-1813) When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory

Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1813?page=all ]

Donald Woods updated GERONIMO-1813:
-----------------------------------

    Fix Version/s: 1.1.x
                   1.2

> When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-1813
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1813
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Hot Deploy Dir
>    Affects Versions: 1.1
>         Environment: Win2k , JDK 1.4.2
>            Reporter: Mansoor
>            Priority: Minor
>             Fix For: 1.1.x, 1.2
>
>         Attachments: hotdeploy_patch1_06042006.txt
>
>
> Hi ,
> Problem :
>        When already an application module say (hello.war) is deployed (either by using manually or hot deploy procedure ) , And when some one try to hot deploy the same application with same or different name ( say hello.war | hello2.war | hello2 directory ) ,  the server throws an exception saying there exists already an application deployed , But doesn't delete the module ( hello.war | hello2.war |  hello2 directory)  from hot deploy directory .
> Thus the next time the server starts , it tries to deploy the same module once again. 
> Here i have a piece of code put into DirectoryHotDeployer.java  file , which can solve the above issue and also to some extend users can get clean picture.
> Basically it deletes the asset from deploy directory ,which got failed to hot deploy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-1813) When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory

Posted by "Donald Woods (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1813?page=all ]

Donald Woods updated GERONIMO-1813:
-----------------------------------

    Attachment: hotdeploy_projectxml_06042006.txt

Also need to apply hotdeploy_projectxml_06042006.txt (which was created against the latest 1.1.1 branch), which includes geronimo-deployment jar for the new dependency on org.apache.geronimo.deployment.util.DeploymentUtil.

> When already deployed application is hot deployed once gain , Server doesn't delete the module from hot deployed directory
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-1813
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1813
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Hot Deploy Dir
>    Affects Versions: 1.1
>         Environment: Win2k , JDK 1.4.2
>            Reporter: Mansoor
>            Priority: Minor
>             Fix For: 1.1.x, 1.2
>
>         Attachments: hotdeploy_patch1_06042006.txt, hotdeploy_projectxml_06042006.txt
>
>
> Hi ,
> Problem :
>        When already an application module say (hello.war) is deployed (either by using manually or hot deploy procedure ) , And when some one try to hot deploy the same application with same or different name ( say hello.war | hello2.war | hello2 directory ) ,  the server throws an exception saying there exists already an application deployed , But doesn't delete the module ( hello.war | hello2.war |  hello2 directory)  from hot deploy directory .
> Thus the next time the server starts , it tries to deploy the same module once again. 
> Here i have a piece of code put into DirectoryHotDeployer.java  file , which can solve the above issue and also to some extend users can get clean picture.
> Basically it deletes the asset from deploy directory ,which got failed to hot deploy

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira