You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Vadim Zaliva (JIRA)" <ji...@apache.org> on 2009/01/15 23:44:00 UTC
[jira] Created: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
find Max Tuple by 1st field UDF (for piggybank)
-----------------------------------------------
Key: PIG-620
URL: https://issues.apache.org/jira/browse/PIG-620
Project: Pig
Issue Type: New Feature
Components: impl
Affects Versions: types_branch
Reporter: Vadim Zaliva
Fix For: types_branch
This is simple UDF which takes bag of tuples and returns one with max. 1st column.
It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665672#action_12665672 ]
Alan Gates commented on PIG-620:
--------------------------------
Thanks for the patch. A couple of comments. One, the file needs the Apache header. Two, you have a println at the end of max() detailing the tuple being returned. That looks like a debug statement. Did you intend to leave it in there?
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Vadim Zaliva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Zaliva updated PIG-620:
-----------------------------
Comment: was deleted
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Vadim Zaliva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Zaliva updated PIG-620:
-----------------------------
Status: Patch Available (was: Open)
implementation
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (PIG-620) find Max Tuple by 1st field UDF (for piggybank)
Posted by Alan Gates <ga...@yahoo-inc.com>.
I can do them. I wanted to check about the println before I removed it.
Alan.
On Jan 20, 2009, at 5:41 PM, Vadim Zaliva (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665677
> #action_12665677 ]
>
> Vadim Zaliva commented on PIG-620:
> ----------------------------------
>
> Sorry about println, it was a debug statement and should be removed.
>
> I was not aware about apache header. I guess it could be added if
> needed.
>
> Do you want me to resubmit or committer can do these 2 trivial
> changes (1. remove print, 2. add header) before committing?
>
>
>
>
>> find Max Tuple by 1st field UDF (for piggybank)
>> -----------------------------------------------
>>
>> Key: PIG-620
>> URL: https://issues.apache.org/jira/browse/PIG-620
>> Project: Pig
>> Issue Type: New Feature
>> Components: impl
>> Affects Versions: types_branch
>> Reporter: Vadim Zaliva
>> Fix For: types_branch
>>
>> Attachments: MaxTupleBy1stField.java
>>
>>
>> This is simple UDF which takes bag of tuples and returns one with
>> max. 1st column.
>> It is fairly trivial but I have seen people asking for it. Detailed
>> usage comments are in Javadoc.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Vadim Zaliva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665677#action_12665677 ]
Vadim Zaliva commented on PIG-620:
----------------------------------
Sorry about println, it was a debug statement and should be removed.
I was not aware about apache header. I guess it could be added if needed.
Do you want me to resubmit or committer can do these 2 trivial changes (1. remove print, 2. add header) before committing?
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates reassigned PIG-620:
------------------------------
Assignee: Vadim Zaliva
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: 0.2.0
> Reporter: Vadim Zaliva
> Assignee: Vadim Zaliva
> Fix For: 0.2.0
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Vadim Zaliva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Zaliva updated PIG-620:
-----------------------------
Attachment: MaxTupleBy1stField.java
implementation
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIG-620) find Max Tuple by 1st field
UDF (for piggybank)
Posted by "Vadim Zaliva (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664304#action_12664304 ]
vzaliva edited comment on PIG-620 at 1/15/09 2:44 PM:
-----------------------------------------------------------
implementation attached
was (Author: vzaliva):
implementation
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-620) find Max Tuple by 1st field UDF (for
piggybank)
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan Gates updated PIG-620:
---------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed after adding the apache header and removing printlns. Thanks Vadim for the contribution.
> find Max Tuple by 1st field UDF (for piggybank)
> -----------------------------------------------
>
> Key: PIG-620
> URL: https://issues.apache.org/jira/browse/PIG-620
> Project: Pig
> Issue Type: New Feature
> Components: impl
> Affects Versions: types_branch
> Reporter: Vadim Zaliva
> Fix For: types_branch
>
> Attachments: MaxTupleBy1stField.java
>
>
> This is simple UDF which takes bag of tuples and returns one with max. 1st column.
> It is fairly trivial but I have seen people asking for it. Detailed usage comments are in Javadoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.