You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by sh...@apache.org on 2009/01/11 12:54:41 UTC

svn commit: r733458 - /lucene/solr/trunk/src/java/org/apache/solr/handler/component/QueryComponent.java

Author: shalin
Date: Sun Jan 11 03:54:41 2009
New Revision: 733458

URL: http://svn.apache.org/viewvc?rev=733458&view=rev
Log:
SOLR-450 -- Validate start param to be non-negative and show friendly error message

Modified:
    lucene/solr/trunk/src/java/org/apache/solr/handler/component/QueryComponent.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/handler/component/QueryComponent.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/component/QueryComponent.java?rev=733458&r1=733457&r2=733458&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/handler/component/QueryComponent.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/handler/component/QueryComponent.java Sun Jan 11 03:54:41 2009
@@ -120,6 +120,10 @@
     SolrIndexSearcher searcher = req.getSearcher();
     SolrParams params = req.getParams();
 
+    if (rb.getQueryCommand().getOffset() < 0) {
+      throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "'start' parameter cannot be negative");
+    }
+
     // -1 as flag if not set.
     long timeAllowed = (long)params.getInt( CommonParams.TIME_ALLOWED, -1 );