[GitHub] [arrow-rs] alamb commented on a change in pull request #1173: Update test output for Rust 1.58 release

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #1173:
URL: https://github.com/apache/arrow-rs/pull/1173#discussion_r784988514



##########
File path: parquet/src/record/api.rs
##########
@@ -1081,9 +1081,9 @@ mod tests {
     fn test_convert_float_to_string() {
         assert_eq!(format!("{}", Field::Float(1.0)), "1.0");
         assert_eq!(format!("{}", Field::Float(9.63)), "9.63");
-        assert_eq!(format!("{}", Field::Float(1e-15)), "0.000000000000001");
+        assert_eq!(format!("{}", Field::Float(1e-15)), "1e-15");

Review comment:
       I don't really know if this is correct output or not
   
   The code that handles formatting this is here: https://github.com/apache/arrow-rs/blob/master/parquet/src/record/api.rs#L716-L729
   
   Which came in from @sunchao  in the original donation 3 years ago in https://github.com/apache/arrow-rs/commit/6d12823d6665f86eb2e410af7577fe90a83ad46b 
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org