You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "jagan-parthiban (via GitHub)" <gi...@apache.org> on 2023/07/09 05:05:37 UTC

[GitHub] [trafficcontrol] jagan-parthiban opened a new pull request, #7623: Removed TryIfModifiedSinceQuery from servicecategories.go and reused from ims.go

jagan-parthiban opened a new pull request, #7623:
URL: https://github.com/apache/trafficcontrol/pull/7623

   **Closes**: No related Issues
   
   
   
   <!-- **^ Add meaningful description above** --><hr/>
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   The Get request to **service_category** api with **If-Modified-Since** should return **304**. 
   
   ```
   curl --request GET \
     --url https://localhost:8443/api/5.0/service_categories \
     --header 'If-Modified-Since: Mon, 04 Jul 2024 18:00:00 IST'
   ```
   
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - 7.0.1
   
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] codecov[bot] commented on pull request #7623: Removed TryIfModifiedSinceQuery from servicecategories.go and reused from ims.go

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7623:
URL: https://github.com/apache/trafficcontrol/pull/7623#issuecomment-1627606702

   ## [Codecov](https://app.codecov.io/gh/apache/trafficcontrol/pull/7623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#7623](https://app.codecov.io/gh/apache/trafficcontrol/pull/7623?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7390d5f) into [master](https://app.codecov.io/gh/apache/trafficcontrol/commit/8a08e3b187de43bd78188feda005dc75a445fd6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8a08e3b) will **decrease** coverage by `4.51%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7623      +/-   ##
   ============================================
   - Coverage     30.13%   25.63%   -4.51%     
     Complexity       98       98              
   ============================================
     Files           794      282     -512     
     Lines         84095    19261   -64834     
     Branches        907       90     -817     
   ============================================
   - Hits          25344     4938   -20406     
   + Misses        56622    13989   -42633     
   + Partials       2129      334    -1795     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | golib_unit | `?` | |
   | grove_unit | `4.60% <ø> (ø)` | |
   | t3c_unit | `5.28% <ø> (ø)` | |
   | traffic_monitor_unit | `?` | |
   | traffic_ops_unit | `?` | |
   | traffic_portal_v2 | `?` | |
   | traffic_stats_unit | `10.14% <ø> (ø)` | |
   | unit_tests | `5.58% <ø> (-21.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   [see 512 files with indirect coverage changes](https://app.codecov.io/gh/apache/trafficcontrol/pull/7623/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] rimashah25 merged pull request #7623: Removed TryIfModifiedSinceQuery from servicecategories.go and reused from ims.go

Posted by "rimashah25 (via GitHub)" <gi...@apache.org>.
rimashah25 merged PR #7623:
URL: https://github.com/apache/trafficcontrol/pull/7623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org