You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/10/23 14:26:56 UTC
[GitHub] sijie commented on a change in pull request #1754: Netty allocator
wrapper
sijie commented on a change in pull request #1754: Netty allocator wrapper
URL: https://github.com/apache/bookkeeper/pull/1754#discussion_r227411888
##########
File path: bookkeeper-common-allocator/pom.xml
##########
@@ -0,0 +1,60 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
any reason why we add another module, not add this to bookkeeper-common? I think `allocator` is a common enough component in current bookkeeper codebase, since bookkeeper heavily dependend on netty's buffers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services