You are viewing a plain text version of this content. The canonical link for it is here.
Posted to soap-dev@xml.apache.org by sn...@apache.org on 2002/10/04 15:26:04 UTC
cvs commit: xml-soap/java/src/org/apache/soap/util/xml QName.java
snichol 2002/10/04 06:26:03
Modified: java/src/org/apache/soap/util/xml QName.java
Log:
Submitted by: Pavel Ausianik <Pa...@epam.com>
Reviewed by: Scott Nichol
Refer to: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12540
org.apache.soap.util.xml.QName.matches() do unnecessary memory allocations
Revision Changes Path
1.7 +4 -13 xml-soap/java/src/org/apache/soap/util/xml/QName.java
Index: QName.java
===================================================================
RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/util/xml/QName.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- QName.java 13 Nov 2001 18:24:29 -0000 1.6
+++ QName.java 4 Oct 2002 13:26:03 -0000 1.7
@@ -125,11 +125,7 @@
public int hashCode()
{
- String hash1 = namespaceURI.hashCode() + "";
- String hash2 = localPart.hashCode() + "";
- String hash3 = hash1 + '_' + hash2;
-
- return hash3.hashCode();
+ return namespaceURI.hashCode() + localPart.hashCode();
}
public boolean equals(Object obj)
@@ -141,14 +137,9 @@
public boolean matches(Node node)
{
- try
- {
- return (node != null && this.equals(new QName(node)));
- }
- catch (IllegalArgumentException e)
- {
- return false;
- }
+ return (node != null
+ && namespaceURI.equals(node.getNamespaceURI())
+ && localPart.equals(node.getLocalName()));
}
public String toString()
--
To unsubscribe, e-mail: <ma...@xml.apache.org>
For additional commands, e-mail: <ma...@xml.apache.org>