You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/11 15:57:59 UTC

[GitHub] [superset] diegomedina248 commented on a diff in pull request #20670: feat: Add resize drag handle to Dataset SQL fields

diegomedina248 commented on code in PR #20670:
URL: https://github.com/apache/superset/pull/20670#discussion_r918104185


##########
superset-frontend/src/explore/components/controls/TextAreaControl.jsx:
##########
@@ -45,6 +45,16 @@ const propTypes = {
   ]),
   aboveEditorSection: PropTypes.node,
   readOnly: PropTypes.bool,
+  resize: PropTypes.oneOf([
+    null,

Review Comment:
   not necessarily, cause `none` will actually set the css, whereas null will do nothing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org