Re: [PR] Core: Add EnvironmentContext to commit summary [iceberg]

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #9273:
URL: https://github.com/apache/iceberg/pull/9273#discussion_r1497028069


##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -109,6 +110,7 @@ public void testRewriteDataFilesOnPartitionTable() {
 
     List<Object[]> actualRecords = currentData();
     assertEquals("Data after compaction should not change", expectedRecords, actualRecords);
+    assertThat(snapshotSummary()).containsKey(CatalogProperties.APP_ID);

Review Comment:
   I think it's generally better to just add a separate small test that makes sure app-id / engine-version / engine-name are present in the summary



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org