[GitHub] [hive] vineetgarg02 commented on a change in pull request #746: HIVE-22074: Slow compilation due to IN to OR transformation

[GitBox <gi...@apache.org>]

vineetgarg02 commented on a change in pull request #746: HIVE-22074: Slow compilation due to IN to OR transformation
URL: https://github.com/apache/hive/pull/746#discussion_r311773334
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
 ##########
 @@ -1220,16 +1220,26 @@ protected ExprNodeDesc getXpathOrFuncExprNodeDesc(ASTNode expr,
             }
             outputOpList.add(nullConst);
           }
+
           if (!ctx.isCBOExecuted()) {
-            ArrayList<ExprNodeDesc> orOperands = TypeCheckProcFactoryUtils.rewriteInToOR(children);
-            if (orOperands != null) {
-              if (orOperands.size() == 1) {
-                orOperands.add(new ExprNodeConstantDesc(TypeInfoFactory.booleanTypeInfo, false));
+
+            HiveConf conf;
+            try {
+              conf = Hive.get().getConf();
 
 Review comment:
   @jcamachor `ctx` is passed on to `genExprNode` by the callers. There are several callers which uses `genExprNode`. For this we will have to update all of these callers to set the config in `TypeCheckCtx`. 
   Fetching HiveConf only occurs if the expression at hand is  `GenericUDFIn` and CBO wasn't executed therefore this shouldn't add much overhead.
   Let me know if you think otherwise

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org