Review Request: Make sure you clean up the cgroups test.

[Brenden Matthews <br...@diddyinc.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10933/
-----------------------------------------------------------

Review request for mesos.


Description
-------

>From e12c858c09e8b59086e9067ef997dfa8a6b484f3 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Fri, 3 May 2013 10:02:44 -0700
Subject: [PATCH 9/9] Make sure you clean up the cgroups test.

Sometimes the cgroup test fails because the directory is already there.
This should ensure that it gets cleanup up in that case before we exit.
---
 src/slave/cgroups_isolator.cpp |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


Diffs
-----

  src/slave/cgroups_isolator.cpp f12fd48 

Diff: https://reviews.apache.org/r/10933/diff/


Testing
-------

Used in production at airbnb.


Thanks,

Brenden Matthews

Re: Review Request: Make sure you clean up the cgroups test.

[Ben Mahler <be...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10933/#review20230
-----------------------------------------------------------



src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/10933/#comment41483>

    Hm.. prior to creating, can you first remove the test cgroup if it exists?
    
    Try<bool> exists = cgroups::exists(hierarchy, path::join(flags.cgroups_root, "test");
    
    CHECK_SOME(exists)
      << "Failed to determine if '"<< path::join(flags.cgroups_root, "test") << "' cgroup "
        << " exists in the hierarchy at '" << hierarchy << "'";
    
    if (exists.get()) {
      // remove
    }
    
    benh is also working on some testing cleanup so I'll point him to this to see if he is aware of such an issue


- Ben Mahler


On May 3, 2013, 6:43 p.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10933/
> -----------------------------------------------------------
> 
> (Updated May 3, 2013, 6:43 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> From e12c858c09e8b59086e9067ef997dfa8a6b484f3 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Fri, 3 May 2013 10:02:44 -0700
> Subject: [PATCH 9/9] Make sure you clean up the cgroups test.
> 
> Sometimes the cgroup test fails because the directory is already there.
> This should ensure that it gets cleanup up in that case before we exit.
> ---
>  src/slave/cgroups_isolator.cpp |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.cpp f12fd48 
> 
> Diff: https://reviews.apache.org/r/10933/diff/
> 
> 
> Testing
> -------
> 
> Used in production at airbnb.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>