[GitHub] [kyuubi] turboFei commented on a diff in pull request #4214: Trace ExecuteStatement operation exec time histogram

["turboFei (via GitHub)" <gi...@apache.org>]

turboFei commented on code in PR #4214:
URL: https://github.com/apache/kyuubi/pull/4214#discussion_r1091392477


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala:
##########
@@ -133,9 +133,12 @@ class ExecuteStatement(
         }
         sendCredentialsIfNeeded()
       }
-      MetricsSystem.tracing(_.updateHistogram(
-        MetricRegistry.name(MetricsConstants.OPERATION_EXEC_TIME, opType),
-        System.currentTimeMillis() - startTime))
+      MetricsSystem.tracing { ms =>
+        val execTime = System.currentTimeMillis() - startTime
+        ms.updateHistogram(

Review Comment:
   easy to scale out, if I want to add user level exec time histogram.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org