You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2019/01/07 17:25:28 UTC

systests/jax-rs JAXRSRxJava2FlowableTest

Hi Andriy,

I noticed the JAXRSRxJava2FlowableTest is not working properly with JDK 11.
With JDK 8 the exception is along the lines of:

  ComposedException 2 :
    java.lang.ClassCastException: javax.ws.rs.NotFoundException cannot be
cast to java.util.concurrent.ExecutionException

whereas with JDK 11 it's:

  ComposedException 2 :
    java.lang.ClassCastException: class javax.ws.rs.NotFoundException
cannot be cast to class java.util.concurrent.ExecutionException
(javax.ws.rs.NotFoundException is in unnamed module of loader 'app';
java.util.concurrent.ExecutionException is in module java.base of loader
'bootstrap')

I guess we are not properly testing the expected exception with JDK11.

Colm.


-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: systests/jax-rs JAXRSRxJava2FlowableTest

Posted by Andrey Redko <dr...@gmail.com>.

Hey Colm,

I haven't seen them failing on Jenkins, strangely, but I will take a look
tonight for sure, thanks a lot for noticing that!

Best Regards,
    Andriy Redko

On Mon, Jan 7, 2019, 12:25 PM Colm O hEigeartaigh <coheigea@apache.org
wrote:

> Hi Andriy,
>
> I noticed the JAXRSRxJava2FlowableTest is not working properly with JDK
> 11. With JDK 8 the exception is along the lines of:
>
>   ComposedException 2 :
>     java.lang.ClassCastException: javax.ws.rs.NotFoundException cannot be
> cast to java.util.concurrent.ExecutionException
>
> whereas with JDK 11 it's:
>
>   ComposedException 2 :
>     java.lang.ClassCastException: class javax.ws.rs.NotFoundException
> cannot be cast to class java.util.concurrent.ExecutionException
> (javax.ws.rs.NotFoundException is in unnamed module of loader 'app';
> java.util.concurrent.ExecutionException is in module java.base of loader
> 'bootstrap')
>
> I guess we are not properly testing the expected exception with JDK11.
>
> Colm.
>
>
> --
> Colm O hEigeartaigh
>
> Talend Community Coder
> http://coders.talend.com
>

Re: systests/jax-rs JAXRSRxJava2FlowableTest

Posted by Colm O hEigeartaigh <co...@apache.org>.

Thanks Andriy!

Colm.

On Tue, Jan 8, 2019 at 3:28 AM Andriy Redko <dr...@gmail.com> wrote:

> Hi Colm,
>
> Indeed, checked the test cases and you are absolutely correct, some of
> them were not doing the right thing. I have refactored those to use the
> dedicated test scaffolding and assertions, should be all good now. Thanks a
> lot!
>
> Best Regards,
>     Andriy Redko
>
> COh> Hi Andriy,
>
>
> COh> I noticed the JAXRSRxJava2FlowableTest is not working properly with
> JDK 11. With JDK 8 the exception is along the lines of:
>
>
> COh>   ComposedException 2 :
> COh>     java.lang.ClassCastException: javax.ws.rs.NotFoundException
> cannot be cast to java.util.concurrent.ExecutionException
>
>
>
> COh> whereas with JDK 11 it's:
>
>
> COh>   ComposedException 2 :
> COh>     java.lang.ClassCastException: class javax.ws.rs.NotFoundException
> cannot be cast to class
> COh> java.util.concurrent.ExecutionException
> (javax.ws.rs.NotFoundException is in unnamed module of loader 'app';
> COh> java.util.concurrent.ExecutionException is in module java.base of
> loader 'bootstrap')
>
>
>
> COh> I guess we are not properly testing the expected exception with JDK11.
>
>
> COh> Colm.
>
>
>
>
>

-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Re: systests/jax-rs JAXRSRxJava2FlowableTest

Posted by Andriy Redko <dr...@gmail.com>.

Hi Colm,

Indeed, checked the test cases and you are absolutely correct, some of them were not doing the right thing. I have refactored those to use the dedicated test scaffolding and assertions, should be all good now. Thanks a lot!

Best Regards,
    Andriy Redko

COh> Hi Andriy,


COh> I noticed the JAXRSRxJava2FlowableTest is not working properly with JDK 11. With JDK 8 the exception is along the lines of:


COh>   ComposedException 2 :
COh>     java.lang.ClassCastException: javax.ws.rs.NotFoundException cannot be cast to java.util.concurrent.ExecutionException



COh> whereas with JDK 11 it's:


COh>   ComposedException 2 :
COh>     java.lang.ClassCastException: class javax.ws.rs.NotFoundException cannot be cast to class
COh> java.util.concurrent.ExecutionException (javax.ws.rs.NotFoundException is in unnamed module of loader 'app';
COh> java.util.concurrent.ExecutionException is in module java.base of loader 'bootstrap')



COh> I guess we are not properly testing the expected exception with JDK11.


COh> Colm.