You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ya...@apache.org on 2024/01/12 07:29:53 UTC

(spark) branch master updated: [MINOR][K8S] Remove unused local val `outstanding` from `ExecutorPodsAllocator#onNewSnapshots`

This is an automated email from the ASF dual-hosted git repository.

yao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a8c1bca4fff [MINOR][K8S] Remove unused local val `outstanding` from `ExecutorPodsAllocator#onNewSnapshots`
3a8c1bca4fff is described below

commit 3a8c1bca4fffaf4185bd0729f24f30e732ba72a4
Author: yangjie01 <ya...@baidu.com>
AuthorDate: Fri Jan 12 15:29:38 2024 +0800

    [MINOR][K8S] Remove unused local val `outstanding` from `ExecutorPodsAllocator#onNewSnapshots`
    
    ### What changes were proposed in this pull request?
    This pr just remove unused local `val outstanding`  from `ExecutorPodsAllocator#onNewSnapshots`, the `outstanding > 0` replaced by `newlyCreatedExecutorsForRpId.nonEmpty` after SPARK-36052 | https://github.com/apache/spark/pull/33492
    
    ### Why are the changes needed?
    Remove unused local val
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    Pass GitHub Actions
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No
    
    Closes #44703 from LuciferYang/minor-val-outstanding.
    
    Authored-by: yangjie01 <ya...@baidu.com>
    Signed-off-by: Kent Yao <ya...@apache.org>
---
 .../org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala   | 1 -
 1 file changed, 1 deletion(-)

diff --git a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
index 236dfff9ac11..ae0eddb10549 100644
--- a/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
+++ b/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
@@ -366,7 +366,6 @@ class ExecutorPodsAllocator(
       // in the snapshot state. Since the messages are a little spammy, avoid them when we know
       // there are no useful updates.
       if (log.isDebugEnabled && snapshots.nonEmpty) {
-        val outstanding = pendingCountForRpId + newlyCreatedExecutorsForRpId.size
         if (currentRunningCount >= targetNum && !dynamicAllocationEnabled) {
           logDebug(s"Current number of running executors for ResourceProfile Id $rpId is " +
             "equal to the number of requested executors. Not scaling up further.")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org