You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/22 03:00:16 UTC

[GitHub] [spark] johnlinp edited a comment on issue #25785: [SPARK-27812][CORE] Explicit System.exit after job's main

johnlinp edited a comment on issue #25785:
URL: https://github.com/apache/spark/pull/25785#issuecomment-617518819


   @igorcalabria After upgrading Spark to 2.4.5 (with your PR #26152 included), there is no more non-daemon threads produced by Spark. In addition to that, `SparkSession` implements `Closeable`, so shutdown hooks should call `stop()` implicitly. Does that mean we don't need to explicitly call `stop()` in application anymore?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org