[GitHub] [hadoop] mehakmeet commented on a diff in pull request #5780: HADOOP-18781. ABFS Output stream thread pools getting shutdown during GC.

["mehakmeet (via GitHub)" <gi...@apache.org>]

mehakmeet commented on code in PR #5780:
URL: https://github.com/apache/hadoop/pull/5780#discussion_r1253884184


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java:
##########
@@ -493,6 +494,12 @@ public synchronized void close() throws IOException {
     }
 
     try {
+      // Check if Executor Service got shutdown before the writes could be
+      // completed.
+      if (hasActiveBlockDataToUpload() && executorService.isShutdown()) {
+        throw new IOException("Executor Service closed before writes could be"

Review Comment:
   Okay. I intentionally left it to be IOE with no path, since that was being added inside of `wrapException()` anyways. 
   Here's how it looked 
   ```
   exception: Failed with java.io.IOException while processing file/directory :[/test/testAbfsThreadPool5ed597ff7617] in method:[Executor Service closed before writes could be completed.]
   ```
   Also, since in `wrapException()` we explicitly check if this is an instance PathIOE, we simply throw it back, we may not require a boolean.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org