[GitHub] zeppelin issue #2201: [ZEPPELIN-1965] Livy SQL Interpreter: Should use df.sh...

[benoyantony <gi...@git.apache.org>]

Github user benoyantony commented on the issue:

    https://github.com/apache/zeppelin/pull/2201
  
    It should not break anything as the property name remains same as before.
    The documentation had a typo in it. It was missing 'sql' in it.
    
    If it's confusing, I can do it as a separate fix.
    
    On Mar 31, 2017 8:48 PM, "Felix Cheung" <no...@github.com> wrote:
    
    > *@felixcheung* commented on this pull request.
    > ------------------------------
    >
    > In docs/interpreter/livy.md
    > <https://github.com/apache/zeppelin/pull/2201#discussion_r109276567>:
    >
    > > @@ -56,14 +56,14 @@ Example: `spark.driver.memory` to `livy.spark.driver.memory`
    >      <td>URL where livy server is running</td>
    >    </tr>
    >    <tr>
    > -    <td>zeppelin.livy.spark.maxResult</td>
    > +    <td>zeppelin.livy.spark.sql.maxResult</td>
    >
    > I love this, but it might break existing users. Perhaps we don't change
    > this for now?
    >
    > \u2014
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/zeppelin/pull/2201#pullrequestreview-30373736>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AB1uyu_U3xz4WnpFAGISqFZMWZSy3q8Jks5rrckIgaJpZM4Msjp1>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---